1196425 - [Music][NGA] Implement 'open' and 'pick' activity handlers

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Justin D'Arcangelo [:justindarc]]

The NGA Music app needs to respond to 'open' and 'pick' activities to replicate the functionality of the OGA Music app.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1196425 > mozilla-b2g:master

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8650278 [details] [review]
[gaia] justindarc:bug1196425 > mozilla-b2g:master

This is based on the patch for Bug 1195428, so you only need to look at the 2nd commit until Bug 1195428 lands.

Comment 3

[Jim Porter (:squib)]

Comment on attachment 8650278 [details] [review]
[gaia] justindarc:bug1196425 > mozilla-b2g:master

Looks good basically, but r- for the database changes. I don't think we should require users of the database API to know that they need to wait until the DB is enumerable/ready.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8650278 [details] [review]
[gaia] justindarc:bug1196425 > mozilla-b2g:master

Addressed your CSS concerns. Would like to make the more aggressive changes to db.js as part of Bug 1196414 if that is ok with you. In Bug 1196414, I merged all of the latest OGA changes to db.js in and it would be difficult to rebase on top of this patch if we made the changes you suggested here.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Marking as blocked by Bug 1199429 since this patch needs updated to fix issue with activities in OGA Music app before it can land.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/ccddf1824ac6da0ebb4b4433dbfd6dd21cbf7aca

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing frequent Gij music_test.js failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=2639339&repo=b2g-inbound

https://github.com/mozilla-b2g/gaia/commit/0275bfb88531a999a8b3553b544fa0613e52f9bd

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1196425-v2 > mozilla-b2g:master

Comment 9

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8655070 [details] [review]
[gaia] justindarc:bug1196425-v2 > mozilla-b2g:master

Carrying over R+ for patch.

Hub: Can you review the Music OGA integration test changes? Thanks!

Comment 10

[Hubert Figuiere [:hub]]

Comment on attachment 8655070 [details] [review]
[gaia] justindarc:bug1196425-v2 > mozilla-b2g:master

r=me

pending the test run green

Comment 11

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/4a9a954acbe032e8557fc5fe4d1187e392d905b8