Cleanup unused configs in linux/mac/win_unittests.py in mozharness

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: vaibhav1994, Assigned: vaibhav1994)

Tracking

unspecified

Firefox Tracking Flags

(firefox43 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I was going through the mozharness, buildbot code and I saw that there are unused configs in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/unittests/linux_unittest.py?offset=700#62-66

I spent a good amount of time to see if those variables were called from buildbot anywhere, I could not find any, so we should remove them if they are not used.
(Assignee)

Comment 1

3 years ago
Created attachment 8650098 [details]
MozReview Request: Bug 1196428 - Cleaning up unused configs in linux/mac/win_unittests.py in mozharness. r=jlund

Bug 1196428 - Cleaning up unused configs in linux_unittests.py in mozharness. r=jlund
Attachment #8650098 - Flags: review?(jlund)
https://reviewboard.mozilla.org/r/16545/#review14803

::: testing/mozharness/configs/unittests/linux_unittest.py
(Diff revision 1)
> -        "plain1": ["--total-chunks=5", "--this-chunk=1", "--chunk-by-dir=4"],
> -        "plain2": ["--total-chunks=5", "--this-chunk=2", "--chunk-by-dir=4"],
> -        "plain3": ["--total-chunks=5", "--this-chunk=3", "--chunk-by-dir=4"],
> -        "plain4": ["--total-chunks=5", "--this-chunk=4", "--chunk-by-dir=4"],
> -        "plain5": ["--total-chunks=5", "--this-chunk=5", "--chunk-by-dir=4"],

These appear in win_unittest.py and mac_unittest.py as well, we should get rid of them there as well as long as they aren't used.
(Assignee)

Comment 3

3 years ago
Comment on attachment 8650098 [details]
MozReview Request: Bug 1196428 - Cleaning up unused configs in linux/mac/win_unittests.py in mozharness. r=jlund

Bug 1196428 - Cleaning up unused configs in linux/mac/win_unittests.py in mozharness. r=jlund
Attachment #8650098 - Attachment description: MozReview Request: Bug 1196428 - Cleaning up unused configs in linux_unittests.py in mozharness. r=jlund → MozReview Request: Bug 1196428 - Cleaning up unused configs in linux/mac/win_unittests.py in mozharness. r=jlund
(Assignee)

Comment 4

3 years ago
Yes, I checked in win and mac buildbot code too, they were unused.
Summary: Cleanup unused configs in linux_unittests.py in mozharness → Cleanup unused configs in linux/mac/win_unittests.py in mozharness
(Assignee)

Comment 6

3 years ago
The usual command passed from buildbot is this - 
/tools/buildbot/bin/python scripts/scripts/desktop_unittest.py --cfg unittests/linux_unittest.py --mochitest-suite plain-chunked --total-chunks 5 --this-chunk 1 --blob-upload-branch mozilla-inbound --download-symbols ondemand

So just the "plain-chunked" key is called in the logs for various jobs on various branches that I have checked.

Updated

3 years ago
Attachment #8650098 - Flags: review?(jlund) → review+

Comment 8

3 years ago
Comment on attachment 8650098 [details]
MozReview Request: Bug 1196428 - Cleaning up unused configs in linux/mac/win_unittests.py in mozharness. r=jlund

https://reviewboard.mozilla.org/r/16545/#review15017

sweet. thanks for this. I guess these are not used now because we are using a different in-tree config? which I guess might change again now that mh is in tree
(Assignee)

Updated

3 years ago
Assignee: nobody → vaibhavmagarwal
Keywords: checkin-needed
(Assignee)

Comment 9

3 years ago
This patch is ready to be checked in. Can some sheriff check this in please?
https://hg.mozilla.org/mozilla-central/rev/4d45f860006c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.