1196431 - generalize and move editor.js:detectIndentation

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Tom Tromey :tromey]

For as-authored I'd like to be able to invoke detectIndentation
on a string, without requiring a full editor.  So, split this
function out and generalize so it can be used this way as well.
This will be useful to callers of the code added in bug 1195356, though
not needed directly by that patch.

Comment 1

[Tom Tromey :tromey]

Due to dependencies on other parts of the series, I'm going to have to
stick this one into bug 984880.

Comment 2

[Tom Tromey :tromey]

I was confused yesterday, the move bits can go in before the
changes to stylesheets; and this will make the series a bit less
confusing overall.

Comment 3

[Tom Tromey :tromey]

Attachment: generalize detectIndentation and move to new file

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8654218 [details] [diff] [review]
generalize detectIndentation and move to new file

Review of attachment 8654218 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/shared/indentation.js
@@ +42,5 @@
> + * use.  This consults various prefs to arrive at a decision.
> + *
> + * @param {Function} iterFunc A function of three arguments:
> + *        (start, end, callback); where |start| and |end| describe
> + *        which lines of text to examine, and |callback| is a function

s/which lines of text to examine/the range of text lines to examine

::: toolkit/devtools/shared/tests/unit/test_indentation.js
@@ +105,5 @@
> +
> +function test_indent_detection() {
> +  Services.prefs.setIntPref(TAB_SIZE, 2);
> +  Services.prefs.setBoolPref(EXPAND_TAB, true);
> +  Services.prefs.setBoolPref(DETECT_INDENT, true);

You should clear these user prefs when the test ends.

Comment 5

[Tom Tromey :tromey]

Attachment: generalize detectIndentation and move to new file

Updated per review comments.

Comment 6

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0d678eaaed1

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b94c55886a5b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b94c55886a5b