Closed Bug 1196441 Opened 9 years ago Closed 9 years ago

[NGA][Music] reenable overlay tests

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S6 (04Sep)

People

(Reporter: hub, Assigned: hub)

References

Details

Attachments

(1 file, 2 obsolete files)

[gaia] hfiguiere:bug1196441-overlay-tests > mozilla-b2g:master
46 bytes, text/x-github-pull-request
hub
: review+
Details | Review 
reenable overlay tests
Blocks: 1193835
Depends on: 1196414
Target Milestone: --- → FxOS-S6 (04Sep)
Assignee: nobody → hub
Comment on attachment 8651337 [details] [review]
[gaia] hfiguiere:bug1196441-overlay-tests > mozilla-b2g:master

The overlay tests on top of your patches....

Will rebase once yours land, of course.
Attachment #8651337 - Flags: review?(jdarcangelo)
Comment on attachment 8651337 [details] [review]
[gaia] hfiguiere:bug1196441-overlay-tests > mozilla-b2g:master

Looks good, but I left some comments on the PR about whether or not some of the tests should still be skipped.
Attachment #8651337 - Flags: review?(jdarcangelo) → review+
Yes they should still be skipped. They are the activity test. And they aren't working (also missing the supporting files, that's in another PR).


Thanks !
Status: NEW → ASSIGNED
Merged
https://github.com/mozilla-b2g/gaia/commit/17c2fb2368043ae6a067fbfbd107600d60d2a05f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Needs backout too as this will file since the other supporting code has been backed out... *sigh*
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8655174 [details] [review]
[gaia] hfiguiere:bug1196441-overlay-tests > mozilla-b2g:master

r+ carried forward from :justindarc. It was just a backout due to a dependency backed out.
Attachment #8655174 - Flags: review+
Attachment #8651337 - Attachment is obsolete: true
Attachment #8654872 - Attachment is obsolete: true
Merged
https://github.com/mozilla-b2g/gaia/commit/509b3f03af2ff8c94457bf8169e4ae5d6d4790c8
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: