Closed Bug 1196498 Opened 9 years ago Closed 9 years ago

Serialize and deserialize objects' [[class]] names in heap snapshots

Categories

(DevTools :: Memory, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 2 obsolete files)

We don't do that yet, but it is pretty easy and needed for census.
Depends on: 1194424
Attachment #8650532 - Flags: review?(sphink)
Once again, feel free to ignore the CoreDump.pb.{h,cc} files, as those are generated from the CoreDump.proto file by the protobuf compiler.
Comment on attachment 8650532 [details] [diff] [review]
Include objects' [[class]] names in heap snapshots

Review of attachment 8650532 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/CoreDump.proto
@@ +86,5 @@
>      optional uint64     size            = 3;
>      repeated Edge       edges           = 4;
>      optional StackFrame allocationStack = 5;
> +    // char16_t[]
> +    optional bytes      jsObjectClassName = 6;

The comment says char16_t[], but the code says char[]
Attachment #8650532 - Flags: review?(sphink) → review+
Comment on attachment 8651142 [details] [diff] [review]
Include objects' [[class]] names in heap snapshots

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2d2893ddfb1
Attachment #8651142 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9b0aa46d9a94
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: