Closed Bug 1196611 Opened 6 years ago Closed 6 years ago
Drop support for Mercurial 3
40 bytes, text/x-review-board-request
There is some somewhat hacky code in the pushlog extension for transactions that is needed to support Mercurial 3.2. We only run 3.4 in production, so let's remove the legacy code.
pushlog: drop support for Mercurial 3.2 (bug 1196611); r?smacleod We only need to support Mercurial 3.4 in production. This code is pretty hacky. Let's drop support for it. I also cleaned up an unused import that pyflakes warned me about.
Attachment #8650265 - Flags: review?(smacleod)
Comment on attachment 8650265 [details] MozReview Request: pushlog: drop support for Mercurial 3.2 (bug 1196611); r?smacleod https://reviewboard.mozilla.org/r/16599/#review14907 LGTM with the caveat that I didn't actually dig into internals to verify what exactly you're doing makes sense with the mercurial versions. But assuming you know what you're doing there, the code looks fine.
Attachment #8650265 - Flags: review?(smacleod) → review+
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a7c0409592bbf6963791e90c9bf9a1c74d7c374d pushlog: drop support for Mercurial 3.2 (bug 1196611); r=smacleod
https://reviewboard.mozilla.org/r/16599/#review14907 We have very comprehensive test coverage of pushlog with regards to transaction behavior. I'm confident the tests would tell me if we broke things.
Deploying this now...
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.