1196616 - rename internal group fields is_bug_group and is_active

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect, P5)

Description

[:glob ✱]

the internal names for the group fields "is_bug_group" and "is_active" are very misleading and do not reflect their actual function.  this has lead to hard to spot bugs and is a footgun -- it is too easy to assume that setting $group->is_active to false deactivates a group, and changing "use for bugs" in the UI updates $group->is_bug_group.

groups.isbuggroup / $group->is_bug_group

this actually tracks if a group is an internal bugzilla group, or if it's user-created.  these groups can only be created with code.

this should be renamed to "is_system_group" and negated.

groups.isactive / $group->is_active

this actually tracks if a group is a bug group.  when editing groups toggling "use for bugs" sets this field, not "is_bug_group".  in spite of this group's name, bugzilla does not support deactivation of groups.

this should be renamed to "use_for_bugs".

Comment 1

[David Lawrence [:dkl]]

Attachment: 1196616_1_pre.patch

This turned out to be more far reaching the previously thought so it touches quite a lot of files. Also it has to be done in two parts (pre and post) because of the way Bugzilla::Group is used by the checksetup.pl process. 

1. The pre patch will add the new columns and populate the values based on the old columns.
2. And the post patch will remove the old columns and apply all of the rest of the code changes.

dkl

Comment 2

[David Lawrence [:dkl]]

Attachment: 1196616_1_post.patch

Comment 3

[:glob ✱]

dkl and i spoke at length about this change, especially since the scope of the changes are much larger than i expected.

the work that has already happened to generate the patch is useful to identify a potential issues, and with moderate risks we've decided to push this change out so it lands at the same time as the trunk merger.  i'll clear the review requests from these patches.

Comment 4

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   7882c10..4d8b5a3  upstream-merge -> upstream-merge