1196644 - Add OriginAttributes to PermissionSettings

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

mentioned by bholley in
https://bugzilla.mozilla.org/show_bug.cgi?id=1165272#c11

::: dom/permission/PermissionSettings.js
@@ +36,5 @@
>  PermissionSettings.prototype = {
>    get: function get(aPermName, aManifestURL, aOrigin, aBrowserFlag) {
>      debug("Get called with: " + aPermName + ", " + aManifestURL + ", " + aOrigin + ", " + aBrowserFlag);
>      let uri = Services.io.newURI(aOrigin, null, null);
>      let appID = appsService.getAppLocalIdByManifestURL(aManifestURL);

So, we're going to need to update all of this code to operate properly for signedPkg, right? Please file a blocker against bug 1163254 so that we remember to do this (both this stuff and the stuff in PermissionSettings.jsm)

Comment 1

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Assigning to stephanie for now.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Discussed with Jonas, he suggested we should add another attribute like manifestURL into OriginAttributes or create another dictionary, since Gaia uses manifestURL instead of appId.

Comment 3

[Tanvi Vyas[:tanvi]]

Is this b2g specific?  Dave, can you find out?

Comment 4

[Paul Theriault [:pauljt] (no longer reading bugmail)]

(In reply to Tanvi Vyas - out until 1/28 [:tanvi] from comment #3)
> Is this b2g specific?  Dave, can you find out?

Yes - this the for the permissionSettings API (allows the settings app to change permissions for  an origin)

Comment 5

[Dave Huseby [:huseby]]

I think because this is b2g specific, we no longer need to fix this?  Paul can you confirm?

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

agree.