Closed Bug 1196680 Opened 10 years ago Closed 10 years ago

[settings] Hotspot panel header close icon should be grey

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog

People

(Reporter: wilsonpage, Assigned: scottwu)

Details

(Keywords: foxfood, Whiteboard: [good first bug][mentor-lang=zh][bzlite][lang=js])

Attachments

(2 files)

screenshot.png
63.70 KB, image/png
Details
[gaia] scottwu:1196680-panel-header-close-icon-grey > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gasolin
: review+
Details | Review
User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
Attached image screenshot.png —
hey Wilson, I believe this is by design, as its the next logical step. But Przemek can make the final decision.
Flags: needinfo?(pabratowski)
(In reply to Patryk Adamczyk [:patryk] UX from comment #2) > hey Wilson, I believe this is by design, as its the next logical step. But > Przemek can make the final decision. Everywhere else in Gaia the header action button is the same colour as the header text.
Yup, Wilson is correct this should be a transparent version (20% for disabled I believe) of the settings blue.
Flags: needinfo?(pabratowski)
(In reply to Przemek Abratowski [:przemek] UX from comment #4) > Yup, Wilson is correct this should be a transparent version (20% for > disabled I believe) of the settings blue. Przemek, I was arguing that the 'X' (header action button) should be grey. The action button should never be disabled.
Flags: needinfo?(pabratowski)
I see, I was talking about the other side of that header the 'ok'. Yes the 'X' should be grey.
Flags: needinfo?(pabratowski)
QA Whiteboard: [foxfood-triage]
The 'X' in Hotspot Settings panel should be grey.
tracking-b2g: --- → backlog
Component: Gaia::Feedback → Gaia::Settings
Whiteboard: [bzlite] → [good first bug][mentor-lang=zh][bzlite][lang=js]
Just making sure: the 'X' should be grey, whereas 'ok' stays the same?
Assignee: nobody → scwwu
Comment on attachment 8672441 [details] [review] [gaia] scottwu:1196680-panel-header-close-icon-grey > mozilla-b2g:master Just added a new CSS selector to fix this bug.
Attachment #8672441 - Flags: review?(gasolin)
Comment on attachment 8672441 [details] [review] [gaia] scottwu:1196680-panel-header-close-icon-grey > mozilla-b2g:master It works on device, Thanks Scott!
Attachment #8672441 - Flags: review?(gasolin) → review+
Thanks all!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: