Closed
Bug 1196714
Opened 9 years ago
Closed 9 years ago
Convert sdk/core/promise require to require(promise) in devtools codebase
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
|
10.13 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
Some code are still using SDK promise module, via:
const promise = require("sdk/core/promise");
They should be using require("promise") instead, or use DOM Promises.
|
Assignee | |
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38ffbf6d9734
Attachment #8650440 -
Flags: review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da241f433452
Assignee: nobody → poirot.alex
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•