1196717 - Dogfood test - Delete thread in SMS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

https://moztrap.mozilla.org/manage/case/15927/

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8654830 [details] [review]
[gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

I factorized some usage of tap_create_new_contact() and cleaned up the unnecessary comments to the tests impacted. Tell me what you think!

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8654830 [details] [review]
[gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

I don't see a manifest.ini file in the pull request, which would be needed for test_delete_thread.py.

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8654830 [details] [review]
[gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

I can't test test_sms_with_picture_attached.py, that test never worked for me, I guess my sms provider doesn't support mms or something.

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8654830 [details] [review]
[gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

I added some comments and questions in the pull request.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8654830 [details] [review]
[gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

Thanks for the review. I updated according to your comments.

From my side test_sms_with_picture_attached.py passes correctly.

Comment 7

[Martijn Wargers (dead)]

Comment on attachment 8654830 [details] [review]
[gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

Looks good.
I added some questions in the pull request (which is an ongoing discussion). If you really think the things that I have questions about, are necessary, then please keep them.

Comment 8

[John Dorlus [:Silne30]]

Comment on attachment 8654830 [details] [review]
[gaia] JohanLorenzo:bug-1196717 > mozilla-b2g:master

Sorry this took so long.

Comment 9

[Johan Lorenzo [:jlorenzo]]

I put the small changes asked in comment 7. Landed in master at: https://github.com/mozilla-b2g/gaia/commit/b6ed22f1e46e72430297cc000f0db53d22a0f10a