1196732 - Delete reading list references in Reader View code

Status: RESOLVED INVALID

(Firefox Graveyard :: Reading List, defect)

Description

[arni2033]

Attachment: 2015.08.20 16-53-33.png

STR:   (Nightly 43.0a1 (2015-08-18))
1. Create pref browser.readinglist.enabled -> true
2. Open page http://kb.mozillazine.org/About:config_entries
3. Click Reader View button in location bar

Result:       You can see reading list buttons on the left
Expectations: Reading list was removed in bug 1184005; all the code referencing it should be deleted

Note:        "Reading List was never completed or enabled on Desktop, so users shouldn't
              be using it" is not a reason to keep unnecessary code in browser

Comment 1

[Mark Hammond [:markh] [:mhammond]]

(In reply to arni2033 from comment #0)
> Note:        "Reading List was never completed or enabled on Desktop, so
> users shouldn't be using it" is not a reason to keep unnecessary code in
> browser

Which is why we removed the reading list code :) But this was obviously missed - thanks.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Ah yeah, that pref remains in the code for Android. We should probably check we aren't desktop before checking that pref, but it doesn't seem like a particularly big deal.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Closing some old readinglist bugs.