Closed Bug 1196737 Opened 9 years ago Closed 9 years ago

Remove redundant NewTabURL.jsm import from browser.js

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: dao, Assigned: isangelawu, Mentored)

References

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

NewTabURL.jsm is already imported in utilityOverlay.js, which is present in every document using browser.js, so this import is redundant and should be removed:

http://hg.mozilla.org/mozilla-central/annotate/29b2df16e961/browser/base/content/browser.js#l57
Hi, Dão Gottwald. I am a newbie here. 
I just submit a patch. could you help to check if this works?
Flags: needinfo?(dao)
Comment on attachment 8650484 [details] [diff] [review]
Remove redundant NewTabURL.jsm import from browser.js

Looks perfect. Thanks!
Flags: needinfo?(dao)
Attachment #8650484 - Flags: review+
Assignee: nobody → isangelawu
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d345e442d7d0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.