Closed
Bug 1196765
Opened 9 years ago
Closed 9 years ago
e10s -- Fix browser/base/content/test/general/browser_bug555767.js - test relies on browser.sessionHistory
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 43
People
(Reporter: tracy, Assigned: tracy)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
6.77 KB,
patch
|
tracy
:
review+
|
Details | Diff | Splinter Review |
This is a spin-off of bug 1093373. The fix that landed there only addressed one of the three reported affected test cases.
Assignee | ||
Comment 1•9 years ago
|
||
try run in progress: https://treeherder.mozilla.org/#/jobs?repo=try&revision=463b928d23ee
Comment 3•9 years ago
|
||
Comment on attachment 8652330 [details] [diff] [review] Patch to fix and re-enable browser chrome test browser_bug555767.js Review of attachment 8652330 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/general/browser_bug555767.js @@ +1,4 @@ > + /* This Source Code Form is subject to the terms of the Mozilla Public > + * License, v. 2.0. If a copy of the MPL was not distributed with this > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > + Check the "splinter view" of your patch in bugzilla, you've accidentally added a great deal of white space to this test file that needs cleaning up. Other than this the patch looks good.
Attachment #8652330 -
Flags: review?(jmathies) → review-
Comment 4•9 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #3) > Comment on attachment 8652330 [details] [diff] [review] > Patch to fix and re-enable browser chrome test browser_bug555767.js > > Review of attachment 8652330 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/base/content/test/general/browser_bug555767.js > @@ +1,4 @@ > > + /* This Source Code Form is subject to the terms of the Mozilla Public > > + * License, v. 2.0. If a copy of the MPL was not distributed with this > > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > > + > > Check the "splinter view" of your patch in bugzilla, you've accidentally > added a great deal of white space to this test file that needs cleaning up. > Other than this the patch looks good. (splinter view is invoked via the "Review" link on the patch you've posted here.)
Assignee | ||
Comment 5•9 years ago
|
||
Hopefully this fixes the mentioned white space.
Attachment #8652330 -
Attachment is obsolete: true
Attachment #8652385 -
Flags: review?(jmathies)
Assignee | ||
Comment 6•9 years ago
|
||
third time's a charm? sorry 'bout that.
Attachment #8652385 -
Attachment is obsolete: true
Attachment #8652385 -
Flags: review?(jmathies)
Attachment #8652395 -
Flags: review?(jmathies)
Updated•9 years ago
|
Attachment #8652395 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8652395 -
Attachment is obsolete: true
Attachment #8652457 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7fe1cc367ef1
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in
before you can comment on or make changes to this bug.
Description
•