Closed Bug 1196765 Opened 6 years ago Closed 6 years ago

e10s -- Fix browser/base/content/test/general/browser_bug555767.js - test relies on browser.sessionHistory

Categories

(Firefox :: Tabbed Browser, defect)

43 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
e10s + ---
firefox43 --- fixed

People

(Reporter: tracy, Assigned: tracy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

This is a spin-off of bug 1093373. The fix that landed there only addressed one of the three reported affected test cases.
Try run passed
Attachment #8652330 - Flags: review?(jmathies)
Comment on attachment 8652330 [details] [diff] [review]
Patch to fix and re-enable browser chrome test browser_bug555767.js

Review of attachment 8652330 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_bug555767.js
@@ +1,4 @@
> +    /* This Source Code Form is subject to the terms of the Mozilla Public
> +     * License, v. 2.0. If a copy of the MPL was not distributed with this
> +     * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +     

Check the "splinter view" of your patch in bugzilla, you've accidentally added a great deal of white space to this test file that needs cleaning up. Other than this the patch looks good.
Attachment #8652330 - Flags: review?(jmathies) → review-
(In reply to Jim Mathies [:jimm] from comment #3)
> Comment on attachment 8652330 [details] [diff] [review]
> Patch to fix and re-enable browser chrome test browser_bug555767.js
> 
> Review of attachment 8652330 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/test/general/browser_bug555767.js
> @@ +1,4 @@
> > +    /* This Source Code Form is subject to the terms of the Mozilla Public
> > +     * License, v. 2.0. If a copy of the MPL was not distributed with this
> > +     * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> > +     
> 
> Check the "splinter view" of your patch in bugzilla, you've accidentally
> added a great deal of white space to this test file that needs cleaning up.
> Other than this the patch looks good.

(splinter view is invoked via the "Review" link on the patch you've posted here.)
Hopefully this fixes the mentioned white space.
Attachment #8652330 - Attachment is obsolete: true
Attachment #8652385 - Flags: review?(jmathies)
Attached patch really removed the white space (obsolete) — Splinter Review
third time's a charm?  sorry 'bout that.
Attachment #8652385 - Attachment is obsolete: true
Attachment #8652385 - Flags: review?(jmathies)
Attachment #8652395 - Flags: review?(jmathies)
Attachment #8652395 - Flags: review?(jmathies) → review+
Attachment #8652395 - Attachment is obsolete: true
Attachment #8652457 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7fe1cc367ef1
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.