Closed Bug 1196816 Opened 6 years ago Closed 6 years ago

Include the build CPU ABI in crash reports

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: snorp, Assigned: snorp)

Details

Attachments

(1 file)

Right now I have no idea how to see on crash-stats if the user was running the wrong APK for their architecture.
Comment on attachment 8650565 [details] [diff] [review]
Include MOZ_APP_ABI in Android crash reports

Review of attachment 8650565 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/CrashReporter.java
@@ +388,5 @@
>              sendPart(os, boundary, "Android_Brand", Build.BRAND);
>              sendPart(os, boundary, "Android_Device", Build.DEVICE);
>              sendPart(os, boundary, "Android_Display", Build.DISPLAY);
>              sendPart(os, boundary, "Android_Fingerprint", Build.FINGERPRINT);
> +            sendPart(os, boundary, "MOZ_APP_ABI", AppConstants.MOZ_APP_ABI);

Maybe "Android_APP_ABI" to be consistent?
Attachment #8650565 - Flags: review?(nchen) → review+
Yes please use something nicer. This gets exposed in the advanced search settings https://crash-stats.mozilla.com/search/?product=FennecAndroid&_dont_run=1
https://hg.mozilla.org/mozilla-central/rev/cf01526b97ce
Assignee: nobody → snorp
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
We will need to get this annotation exposed publicly on the Socorro side as well.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.