1196848 - Add new uid tables to about:memory

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

This will be necessary for evaluating the memory impact of moving tables over to the new key scheme.

Comment 1

[Terrence Cole [:terrence]]

Attachment: add_uid_tables_to_about_memory-v0.diff

I verified that the new measure shows up in about:memory and has a value of 0, as expected.

Comment 2

[Terrence Cole [:terrence]]

Attachment: add_uid_tables_to_about_memory-v1.diff

Sorry to ask for re-review on this, but it was necessary to rewrite the patch it was based on. Specifically, we've moved the uid tables from the Chunk to the Zone, so the new patch reflects the new location and shares very little in common with the prior patch.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/15fa4c3a45ec

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15fa4c3a45ec

Comment 5

[Terrence Cole [:terrence]]

Backing out, since it seems bug 1196847 caused a pretty severe regression on splay.

Comment 6

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03978085dea1

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28dda1c9988d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/28dda1c9988d