Closed Bug 1196848 Opened 9 years ago Closed 9 years ago

Add new uid tables to about:memory

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file, 1 obsolete file)

add_uid_tables_to_about_memory-v1.diff
5.71 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
This will be necessary for evaluating the memory impact of moving tables over to the new key scheme.
I verified that the new measure shows up in about:memory and has a value of 0, as expected.
Attachment #8650681 - Flags: review?(n.nethercote)
Attachment #8650681 - Flags: review?(n.nethercote) → review+
Sorry to ask for re-review on this, but it was necessary to rewrite the patch it was based on. Specifically, we've moved the uid tables from the Chunk to the Zone, so the new patch reflects the new location and shares very little in common with the prior patch.
Attachment #8650681 - Attachment is obsolete: true
Attachment #8655547 - Flags: review?(n.nethercote)
Attachment #8655547 - Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/mozilla-central/rev/15fa4c3a45ec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Backing out, since it seems bug 1196847 caused a pretty severe regression on splay.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/28dda1c9988d
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla43 → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: