1196859 - crash in nsACString_internal::SetCapacity, probably Roboform-related

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Robert Kaiser]

[Tracking Requested - why for this release]:

This bug was filed from the Socorro interface and is 
report bp-356cc853-e0b9-452f-aae7-02aee2150820.
=============================================================


Top Stack Frames:
0 	xul.dll 	nsACString_internal::SetCapacity(unsigned int, mozilla::fallible_t const&) 	xpcom/string/nsTSubstring.cpp
1 	xul.dll 	NS_CopyUnicodeToNative(nsAString_internal const&, nsACString_internal&) 	xpcom/io/nsNativeCharsetUtils.cpp
2 	xul.dll 	nsLocalFile::GetNativePath(nsACString_internal&) 	xpcom/io/nsLocalFileWin.cpp
3 	xul.dll 	js::jit::AssemblerX86Shared::movl(js::jit::Operand const&, js::jit::Register) 	js/src/jit/x86-shared/Assembler-x86-shared.h
4 	xul.dll 	js::Allocate<JSObject, 1>(js::ExclusiveContext*, js::gc::AllocKind, unsigned int, js::gc::InitialHeap, js::Class const*) 	js/src/gc/Allocator.cpp
5 	xul.dll 	XPCWrappedNative::Init(XPCNativeScriptableCreateInfo const*) 	js/xpconnect/src/XPCWrappedNative.cpp
6 	xul.dll 	XPCWrappedNative::GetNewOrUsed(xpcObjectHelper&, XPCWrappedNativeScope*, XPCNativeInterface*, XPCWrappedNative**) 	js/xpconnect/src/XPCWrappedNative.cpp
7 	xul.dll 	XPCConvert::NativeInterface2JSObject(JS::MutableHandle<JS::Value>, nsIXPConnectJSObjectHolder**, xpcObjectHelper&, nsID const*, XPCNativeInterface**, bool, nsresult*) 	js/xpconnect/src/XPCConvert.cpp
8 	user32.dll 	NtUserPeekMessage 	
[...]

This is one of the top crashes with 41 Beta now.

Comment 1

[(Away)]

All the reports I looked at had rf-firefox-40.dll (Roboform).

This is likely to be an SDK mismatch. I guess we should just block the 40 DLL in 41+.

Comment 2

[(Away)]

Attachment: Block rf-firefox-40.dll

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked. David, do you want to request uplift to Beta?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b45f6b6d29f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2b45f6b6d29f

Comment 6

[(Away)]

Comment on attachment 8650626 [details] [diff] [review]
Block rf-firefox-40.dll

Approval Request Comment
[Feature/regressing bug #]: Roboform
[User impact if declined]: crashes
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8650626 [details] [diff] [review]
Block rf-firefox-40.dll

Fixes a crash that has recently spiked. Let's uplift to Beta and Aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f81464f9dc8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a88a432876f