Report the value of xpinstall.signatures.required to FHR

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

(Blocks 1 bug)

Trunk
mozilla43
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox41 fixed, firefox42 fixed, firefox43 fixed)

Details

Attachments

(1 attachment)

No description provided.
Posted patch patchSplinter Review
This adds a few prefs to telemetry:

xpinstall.signatures.required: Tells us if signature checking has been turned off
extensions.autoDisableScopes: Tells us if something has changed the pref controling some sideloading controls
extensions.enabledScopes: Tells us if something has changed the locations we look for add-ons
AddonManager.checkCompatibility: Tells us if application version compatibility checks have been disabled (adding this mostly because I suspect no-one uses it anymore and we might want to remove support for it).
Attachment #8650673 - Flags: review?(benjamin)

Comment 2

4 years ago
Comment on attachment 8650673 [details] [diff] [review]
patch

settings.addonCompatibilityCheckEnabled can't change during runtime, right? If so r+datareview=me
Attachment #8650673 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Comment on attachment 8650673 [details] [diff] [review]
> patch
> 
> settings.addonCompatibilityCheckEnabled can't change during runtime, right?
> If so r+datareview=me

It can if a user modifies the prefs in about:config. What do I need to do in that case?
Flags: needinfo?(benjamin)

Comment 4

4 years ago
Does that matter to you or anyone doing analysis? i.e. do you really want to split subsessions if somebody changes the pref? I'll assume no, and this is fine.
Flags: needinfo?(benjamin)
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> Does that matter to you or anyone doing analysis? i.e. do you really want to
> split subsessions if somebody changes the pref? I'll assume no, and this is
> fine.

The only impact it might have is that it could change which add-ons are active when changed at runtime, but I'm guessing that changing add-ons already creates a new session anyway. Mostly I just want to know how many have this pref set.
Assignee

Updated

4 years ago
Assignee: nobody → dtownsend
https://hg.mozilla.org/mozilla-central/rev/aac9d5e8a700
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8650673 [details] [diff] [review]
patch

Given our concerns over whether or not add-on signing should become mandatory we'd like to understand how many users are manually disabling the pref in as many branches as possible.

Approval Request Comment
[Feature/regressing bug #]: No bug
[User impact if declined]: None
[Describe test coverage new/current, TreeHerder]: On nightly for a week, data is showing up in telemetry
[Risks and why]: Very low risk, this patch just adds some values to the telemetry ping.
[String/UUID change made/needed]: None
Attachment #8650673 - Flags: approval-mozilla-beta?
Attachment #8650673 - Flags: approval-mozilla-aurora?
Comment on attachment 8650673 [details] [diff] [review]
patch

Adding additional telemetry probes on add-on signing. The risk is low, let's uplift to Aurora42 and Beta41.
Attachment #8650673 - Flags: approval-mozilla-beta?
Attachment #8650673 - Flags: approval-mozilla-beta+
Attachment #8650673 - Flags: approval-mozilla-aurora?
Attachment #8650673 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.