1196934 - refactor SETA code to support all jobs types, including new ones

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

SETA has a lot of code which has hardcoded builder names or shorthand matching:
13:28 <jmaher|mtg> https://github.com/dminor/ouija/blob/master/static/js/seta.js#L73
13:30 <jmaher|mtg> https://github.com/dminor/ouija/blob/master/src/server.py#L373
13:30 <jmaher|mtg> https://github.com/dminor/ouija/blob/master/src/server.py#L507
13:31 <jmaher|mtg> https://github.com/dminor/ouija/blob/master/tools/dailyjobs_query.py#L70 <- ignores builds/valgrind
13:32 <jmaher|mtg> https://github.com/dminor/ouija/blob/master/tools/failures.py#L51 <- output
13:33 <jmaher|mtg> https://github.com/dminor/ouija/blob/master/tools/seta.py#L131 <- b2g


With all of this if we had a package that translated for us (bug 1196933), then we could simplify this code and handle new jobs without a big headache.

Ideally this package would be called as an API endpoint from ouija:server.py so we can get the data in python and javascript.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: https://github.com/dminor/ouija/pull/76

first pass of this, I want to have all data transformations in the same area, ideally just an api call.

Comment 2

[Vaibhav (:vaibhav1994)]

Comment on attachment 8659383 [details] [review]
https://github.com/dminor/ouija/pull/76

The first draft looks good, thanks for cleaning up Joel! Left some comments in the PR. Will take another look once they are addressed.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8659383 [details] [review]
https://github.com/dminor/ouija/pull/76

Thank for the comments, I have updated, testing and re pushed some code- please review again.

Comment 4

[Vaibhav (:vaibhav1994)]

Comment on attachment 8659383 [details] [review]
https://github.com/dminor/ouija/pull/76

Minor nit to be addressed in github. Looks good!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

merged to production:
https://github.com/dminor/ouija/commit/a9da2e7f824f88e210107ac78b707a42651c8d3c

I think it is

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

I think this is completed, there are other bugs for additional refactoring.