1197000 - Better debugging output for Safe Browsing list updates

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[François Marier [:francois]]

While debugging https://github.com/mozilla-services/shavar/issues/28, I tweaked a bunch of the existing PR_LOGs to make it easier to debug problems with the update server.

Comment 1

[François Marier [:francois]]

Attachment: MozReview Request: Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8650769 [details]
MozReview Request: Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

https://reviewboard.mozilla.org/r/16681/#review14979

::: toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp:484
(Diff revision 1)
> -        rv = httpChannel->GetResponseStatus(&requestStatus);
> +      rv = httpChannel->GetResponseStatus(&requestStatus);

You're now doing this call even in the non-failure case. Probably want to move this inside the if?

Comment 3

[François Marier [:francois]]

Comment on attachment 8650769 [details]
MozReview Request: Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

(In reply to Gian-Carlo Pascutto [:gcp] from comment #2)
> ::: toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp:484
> (Diff revision 1)
> > -        rv = httpChannel->GetResponseStatus(&requestStatus);
> > +      rv = httpChannel->GetResponseStatus(&requestStatus);
> 
> You're now doing this call even in the non-failure case. Probably want to
> move this inside the if?

Actually, I was thinking it would be useful even in the "succeeded" case, for example to differentiate between a 200 and a 204.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8650769 [details]
MozReview Request: Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

https://reviewboard.mozilla.org/r/16681/#review15001

Ship It!

Comment 5

[François Marier [:francois]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4a6f45c8dad

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25d46daf76f7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25d46daf76f7