Closed Bug 1197000 Opened 7 years ago Closed 7 years ago

Better debugging output for Safe Browsing list updates

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: francois, Assigned: francois)

Details

Attachments

(1 file)

While debugging https://github.com/mozilla-services/shavar/issues/28, I tweaked a bunch of the existing PR_LOGs to make it easier to debug problems with the update server.
Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp
Attachment #8650769 - Flags: review?(gpascutto)
Comment on attachment 8650769 [details]
MozReview Request: Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

https://reviewboard.mozilla.org/r/16681/#review14979

::: toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp:484
(Diff revision 1)
> -        rv = httpChannel->GetResponseStatus(&requestStatus);
> +      rv = httpChannel->GetResponseStatus(&requestStatus);

You're now doing this call even in the non-failure case. Probably want to move this inside the if?
Attachment #8650769 - Flags: review?(gpascutto)
Comment on attachment 8650769 [details]
MozReview Request: Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

(In reply to Gian-Carlo Pascutto [:gcp] from comment #2)
> ::: toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp:484
> (Diff revision 1)
> > -        rv = httpChannel->GetResponseStatus(&requestStatus);
> > +      rv = httpChannel->GetResponseStatus(&requestStatus);
> 
> You're now doing this call even in the non-failure case. Probably want to
> move this inside the if?

Actually, I was thinking it would be useful even in the "succeeded" case, for example to differentiate between a 200 and a 204.
Attachment #8650769 - Flags: review?(gpascutto)
Comment on attachment 8650769 [details]
MozReview Request: Bug 1197000 - Better debugging output for Safe Browsing list updates. r?gcp

https://reviewboard.mozilla.org/r/16681/#review15001

Ship It!
Attachment #8650769 - Flags: review?(gpascutto) → review+
https://hg.mozilla.org/mozilla-central/rev/25d46daf76f7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.