Closed Bug 1197010 Opened 4 years ago Closed 4 years ago
SMS] Android backend for create Message Cursor/create Thread Cursor
No description provided.
This patch: - Moves all the WebSMS related native functions to use GeneratedNatives (SmsManager.h/cpp) - Adapts the existing message list implementation in GeckoSmsManager to implement message cursors instead, and removes the old message list API - Implements thread cursors The SMS app successfully reads inbox threads and messages, but everything is read only so far (need to deal with whether we're the default SMS app or not in other bugs). Missing things: - widget/android/ is probably not the best place for SmsManager.h/cpp to live. Will move it to dom/mobilemessage/android. - We start the SmsIoThread in a static code block in SmsManager.java, but it looks like that only runs when we first access the SmsManager class, so there's a race between initialization of the IO thread and the first Runnable to be posted. This needs to be fixed. :snorp, do you see any obvious red flags here?
Oh, and this probably won't build without MOZ_WEBSMS_BACKEND, but that's just because I was trying to avoid a clobber, it's a trivial fix.
This fixes the race by using a HandlerThread and moves the code to dom/mobilemessage/android.
Attachment #8668521 - Flags: review?(snorp) → review+
Backed out for android build failures: https://treeherder.mozilla.org/logviewer.html#?job_id=2962406&repo=b2g-inbound https://hg.mozilla.org/integration/b2g-inbound/rev/40c5046a6651
…I was running |make update-generated-wrappers| on the wrong objdir :/
You need to log in before you can comment on or make changes to this bug.