Closed Bug 1197010 Opened 4 years ago Closed 4 years ago

[WebSMS] Android backend for createMessageCursor/createThreadCursor

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: reuben, Assigned: reuben)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
This patch:
- Moves all the WebSMS related native functions to use GeneratedNatives (SmsManager.h/cpp)
- Adapts the existing message list implementation in GeckoSmsManager to implement message cursors instead, and removes the old message list API
- Implements thread cursors

The SMS app successfully reads inbox threads and messages, but everything is read only so far (need to deal with whether we're the default SMS app or not in other bugs).

Missing things:
- widget/android/ is probably not the best place for SmsManager.h/cpp to live. Will move it to dom/mobilemessage/android.
- We start the SmsIoThread in a static code block in SmsManager.java, but it looks like that only runs when we first access the SmsManager class, so there's a race between initialization of the IO thread and the first Runnable to be posted. This needs to be fixed.

:snorp, do you see any obvious red flags here?
Attachment #8662701 - Flags: feedback?(snorp)
Oh, and this probably won't build without MOZ_WEBSMS_BACKEND, but that's just because I was trying to avoid a clobber, it's a trivial fix.
This fixes the race by using a HandlerThread and moves the code to dom/mobilemessage/android.
Attachment #8662701 - Attachment is obsolete: true
Attachment #8662701 - Flags: feedback?(snorp)
Attachment #8668521 - Flags: review?(snorp)
Attachment #8668521 - Flags: review?(snorp) → review+
…I was running |make update-generated-wrappers| on the wrong objdir :/
Flags: needinfo?(reuben.bmo)
https://hg.mozilla.org/mozilla-central/rev/92a91d520488
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Duplicate of this bug: 862718
Duplicate of this bug: 1189893
You need to log in before you can comment on or make changes to this bug.