Closed
Bug 1197014
Opened 6 years ago
Closed 6 years ago
Add ThemedFrameLayout
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(2 files)
It's needed in bug 1148550.
Assignee | ||
Comment 2•6 years ago
|
||
Bug 1197014 - Add previous ColorUtils change to template. r=sebastian This was originally implemented in bug 1169435 but not carried over to the template.
Attachment #8650778 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 3•6 years ago
|
||
Bug 1197014 - Add ThemedFrameLayout. r=sebastian Note that this file is auto-generated from generate_themed_views.py.
Attachment #8650779 -
Flags: review?(s.kaspari)
Comment 4•6 years ago
|
||
Comment on attachment 8650778 [details] MozReview Request: Bug 1197014 - Add previous ColorUtils change to template. r=sebastian https://reviewboard.mozilla.org/r/16685/#review14981 Thank you for fixing this. :) r+, do we need some generator too? see below. ::: mobile/android/base/widget/ThemedView.java.frag:2 (Diff revision 1) > // This file is generated by generate_themed_views.py; do not edit. Is it safe to edit this file despite the comment?
Attachment #8650778 -
Flags: review?(s.kaspari) → review+
Comment 5•6 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #4) > ::: mobile/android/base/widget/ThemedView.java.frag:2 > (Diff revision 1) > > // This file is generated by generate_themed_views.py; do not edit. > > Is it safe to edit this file despite the comment? Now I see, this is actually the template for the generator. :-)
Comment 6•6 years ago
|
||
Comment on attachment 8650779 [details] MozReview Request: Bug 1197014 - Add ThemedFrameLayout. r=sebastian https://reviewboard.mozilla.org/r/16687/#review14983 Ship It!
Attachment #8650779 -
Flags: review?(s.kaspari) → review+
Comment 7•6 years ago
|
||
I wonder if we could move the theme functionality to a class we delegate calls to from the Themed* classes and then get rid of the generator (and duplicated code)? It's a bit unpleasant to have all these classes with duplicated code - even if they are generated. Maybe I'm going to explore this a bit in another bug *taking note*. I wish Java would support mixins for something like this. End of off-topic mumbling.
Assignee | ||
Comment 8•6 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/7f2ed2bb2a4ff18450e2d0e3b354564c8f94c4a5 changeset: 7f2ed2bb2a4ff18450e2d0e3b354564c8f94c4a5 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 20 17:11:12 2015 -0700 description: Bug 1197014 - Add previous ColorUtils change to template. r=sebastian This was originally implemented in bug 1169435 but not carried over to the template. url: https://hg.mozilla.org/integration/fx-team/rev/72a2c48d456d61b406423019e5369b16f59525b2 changeset: 72a2c48d456d61b406423019e5369b16f59525b2 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 20 17:12:58 2015 -0700 description: Bug 1197014 - Add ThemedFrameLayout. r=sebastian Note that this file is auto-generated from generate_themed_views.py.
Assignee | ||
Comment 9•6 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #7) > in another bug *taking note*. bug 1197264.
Blocks: 1197264
Comment 10•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f2ed2bb2a4f https://hg.mozilla.org/mozilla-central/rev/72a2c48d456d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•2 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•