Closed Bug 1197014 Opened 5 years ago Closed 5 years ago

Add ThemedFrameLayout

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

MozReview Request: Bug 1197014 - Add previous ColorUtils change to template. r=sebastian
40 bytes, text/x-review-board-request
sebastian
: review+
Details
MozReview Request: Bug 1197014 - Add ThemedFrameLayout. r=sebastian
40 bytes, text/x-review-board-request
sebastian
: review+
Details 
And did a part 0 follow-up to bug 1169435.
Depends on: 1169435
Bug 1197014 - Add previous ColorUtils change to template. r=sebastian

This was originally implemented in bug 1169435 but not carried over to the
template.
Attachment #8650778 - Flags: review?(s.kaspari)
Bug 1197014 - Add ThemedFrameLayout. r=sebastian

Note that this file is auto-generated from generate_themed_views.py.
Attachment #8650779 - Flags: review?(s.kaspari)
Comment on attachment 8650778 [details]
MozReview Request: Bug 1197014 - Add previous ColorUtils change to template. r=sebastian

https://reviewboard.mozilla.org/r/16685/#review14981

Thank you for fixing this. :) r+, do we need some generator too? see below.

::: mobile/android/base/widget/ThemedView.java.frag:2
(Diff revision 1)
>  // This file is generated by generate_themed_views.py; do not edit.

Is it safe to edit this file despite the comment?
Attachment #8650778 - Flags: review?(s.kaspari) → review+
(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> ::: mobile/android/base/widget/ThemedView.java.frag:2
> (Diff revision 1)
> >  // This file is generated by generate_themed_views.py; do not edit.
> 
> Is it safe to edit this file despite the comment?

Now I see, this is actually the template for the generator. :-)
Comment on attachment 8650779 [details]
MozReview Request: Bug 1197014 - Add ThemedFrameLayout. r=sebastian

https://reviewboard.mozilla.org/r/16687/#review14983

Ship It!
Attachment #8650779 - Flags: review?(s.kaspari) → review+
I wonder if we could move the theme functionality to a class we delegate calls to from the Themed* classes and then get rid of the generator (and duplicated code)? It's a bit unpleasant to have all these classes with duplicated code - even if they are generated. Maybe I'm going to explore this a bit in another bug *taking note*. I wish Java would support mixins for something like this. End of off-topic mumbling.
url:        https://hg.mozilla.org/integration/fx-team/rev/7f2ed2bb2a4ff18450e2d0e3b354564c8f94c4a5
changeset:  7f2ed2bb2a4ff18450e2d0e3b354564c8f94c4a5
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Thu Aug 20 17:11:12 2015 -0700
description:
Bug 1197014 - Add previous ColorUtils change to template. r=sebastian

This was originally implemented in bug 1169435 but not carried over to the
template.

url:        https://hg.mozilla.org/integration/fx-team/rev/72a2c48d456d61b406423019e5369b16f59525b2
changeset:  72a2c48d456d61b406423019e5369b16f59525b2
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Thu Aug 20 17:12:58 2015 -0700
description:
Bug 1197014 - Add ThemedFrameLayout. r=sebastian

Note that this file is auto-generated from generate_themed_views.py.
(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> in another bug *taking note*.

bug 1197264.
Blocks: 1197264
https://hg.mozilla.org/mozilla-central/rev/7f2ed2bb2a4f
https://hg.mozilla.org/mozilla-central/rev/72a2c48d456d
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.