1197051 - [EME] Playback stalls after seeking encrypted video (again)

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

This time for a different reason! (see bug 1195939 for STR)

While the fix in bug 1195939 works on beta, on trunk we get hammered by lots of frames after a seek.

Bug 1171257 looks very suspect -- flooding the reader with frames if decode is falling behind.

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: seek-decodeahead.patch

19:42 < jya> I guess here if no frames has been returned to the MDSM ; and it has started playback, the video queue size will become < 1
19:43 < jya> and it will start telling the reader to decode like crazy
19:43 < edwin> I wonder if that condition is triggered by the queue being flushed... say... by a seek?
19:44 < jya> edwin: ah good call

Oh yes indeed.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8650834 [details] [diff] [review]
seek-decodeahead.patch

r? either/or.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc188236a6d3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc188236a6d3

Comment 5

[Ralph Giles (:rillian)]

Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Edwin: Does this affect Adobe EME on Firefox 41? If so we need to uplift.

Comment 7

[Jean-Yves Avenard [:jya]]

I would revert the entire force decode ahead commit. I've done so in patch 2 of bug 1197075

Comment 8

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

(In reply to [PTO] Chris Pearce (:cpearce) from comment #6)
> Edwin: Does this affect Adobe EME on Firefox 41? If so we need to uplift.

41 is unaffected.

Comment 9

[Jean-Yves Avenard [:jya]]

pushed it as part of 
https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=7437f28133fc