1197097 - JSON.stringify should not use context-wide auto-cycle detection

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

Test case 1:
---
a = [{}];
JSON.stringify(a, function(k, v){
  JSON.stringify(a);
  return v;
});
---

Test case 2:
---
a = [{
  toString: () => JSON.stringify(a)
}];
a.join();
---


Expected: Both tests return "[{}]"
Actual: Throws `TypeError: cyclic object value`

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

I'm 99% sure this is a regression from bug 888117, which switched us away from a per-JSON.stringify hashset to a global hashset.  :-(  Bah.  Too bad no one was paying attention to semantics when we over-commoned up there.  Easy fix.  Sort of.

...have I assuaged the worry or made it worse?  :-D

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8650970 [details] [diff] [review]
Patch

Review of attachment 8650970 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/536350cf0da8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/536350cf0da8