1197104 - [Messages][Drafts] Threadless drafts are broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

STR:

* Open Messages app;
* Enter any existing conversation;
* Go back to Inbox;
* Enter New Message view and enter recipient and some message text;
* Go back and save draft;
* Observe Inbox.

Expected result: user should see just saved threadless draft;

Actual result: draft is saved into conversation that user visited on step 2.

It seems the reason is that we don't clean ConversationView.activeThread after patch for bug 1167144. Hence there are other bad consequences of this e.g. New Message header is updated with the text of previously visited conversation in case of contact change and etc.

Comment 1

[Oleg Zasypkin [:azasypkin]]

[Blocking Requested - why for this release]: regression

Steve, can you please take a look?

Thanks!

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comms triage: Functional regression from 2.2.

Comment 3

[Steve Chung [:steveck]]

Sure, will take a look immediately

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] steveck-chung:message-remove-threads-dependency > mozilla-b2g:master

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 8650984 [details] [review]
[gaia] steveck-chung:message-remove-threads-dependency > mozilla-b2g:master

Hi Oleg, I think adding the thread clean in beforeleave with current panel checking should be the most appropriate place. Thanks for filing this bug!

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8650984 [details] [review]
[gaia] steveck-chung:message-remove-threads-dependency > mozilla-b2g:master

Looks good and thanks for the quick fix! Just one my wish at github :)

Comment 7

[Steve Chung [:steveck]]

Thanks, I removed the integration test part.
In master: https://github.com/mozilla-b2g/gaia/commit/7a36b3917dfd681a5bcfb78ef5790fc0f2d52fbd

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: After viewing a thread and backing to save a new draft, user can see the saved draft in messages app.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150823150207
Gaia Revision          cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date              2015-08-23 03:34:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150823.184539
Firmware Date          Sun Aug 23 18:45:51 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150823221817
Gaia Revision          cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date              2015-08-23 03:34:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150823.214038
Firmware Date          Sun Aug 23 21:40:46 UTC 2015
Bootloader             s1

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp