1197128 - Create a dedicated data structure for build informations

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[jonathan.pigree]

Build informations are stored into dicts and accessed via hard coded keys.
Julien resumed this situation pretty well in bug 1194996 :
>Yep, this is what is called everywhere "build_infos".
>This is a dict, that hold all the information required for trying a build from downloading to testing.
>It is created with the info fetching (the patch here) and will be used to download, install, try the build.
>I fully agree that a dict is not anymore a good solution.
>We should write a real class for that, with documentation about the live cycle and so on.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: Create a dedicated data structure for build informations

Heya, quite some changes here! The build infos were all the way in  the code. :)

So some changes. I think the review can't be thorough again, we should be good if we test mozregression very well for that. Everythin should be tested here - command line nightly/inbound bisection, and gui also.

Jonathan, I know you don't have much time, so just a quick feedback will be good. Do you like the overall changes ?

Comment 2

[MikeLing]

Comment on attachment 8651373 [details] [review]
Create a dedicated data structure for build informations

It looks great to me! Just r+ this PR :)

Comment 3

[jonathan.pigree]

I gave it a quick look. It looks good.

Comment 4

[Julien Pagès (:parkouss)]

Thanks guys!

Landed: https://github.com/mozilla/mozregression/commit/cc3248161ee7e41ec405dd98c99c0dd930e8ad2c