1197145 - Add easy zero/bool checks to TimeDuration and TimeStamp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've found myself wanting a quick check for unit-less 0-values on [Base]TimeDuration objects, as currently this can only be done quite verbosely, e.g. |if (duration == TimeDuration(0)|.
By extension, the same could be useful for TimeStamp.

There is already a TimeStamp::IsNull().

Proposed additions:
1. |bool BaseTimeDuration::IsZero() const|, for consistency with TimeStamp::IsNull().
2. |explicit BaseTimeDuration::operator bool() const|, for easy |if (duration)| tests.
3. |explicit TimeStamp::operator bool() const|, for easy |if (timestamp)| tests.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1197145-basetimeduration-timestamp-0-tests.patch

Implementation of BaseTimeDuration::IsZero(), BaseTimeDuration::operator bool(), TimeStamp::operator bool().

Happy to discuss whether we actually need&want any/all of these.
Also I could split them in separate patches if preferred.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1197145-basetimeduration-timestamp-0-tests.patch v2

(Sorry for the new rev, fixed a compilation error on Windows.)

Implementation of BaseTimeDuration::IsZero(), BaseTimeDuration::operator bool(), TimeStamp::operator bool().

Happy to discuss whether we actually need&want any/all of these.
Also I could split them in separate patches if preferred.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6909d3c9310f

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/332b56e30115

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/332b56e30115