Closed
Bug 1197146
Opened 9 years ago
Closed 9 years ago
Convert assorted element commands in listener to use new dispatching technique
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox42 affected, firefox43 fixed)
RESOLVED
FIXED
mozilla43
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-server)
Attachments
(8 files)
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
40 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
Assorted element commands implemented by listener not yet converted: - isElementDisplayed - getElementValueOfCssProperty - sendKeysToElement - getElementLocation - clearEleemnt - findElementContent - findElementsContent
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Summary: Convert listener assorted element commands to use new dispatching technique → Convert assorted element commands in listener to use new dispatching technique
|
|
Assignee | |
Comment 1•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6010c833556b
|
|
Assignee | |
Comment 2•9 years ago
|
||
Bug 1197146: Part 1: Prime dispatcher in listener to resolve promises Because of the asynchronous behaviour of some internal utilities, such as ElementManager, we need to employ promises to create a bridge over them and the synchronous returning functions. r=dburns
Attachment #8651058 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Bug 1197146: Part 2: Use dispatcher for listener findElementsContent r=dburns
Attachment #8651059 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Bug 1197146: Part 3: Use dispatcher for listener findElementContent r=dburns
Attachment #8651060 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Bug 1197146: Part 4: Use dispatcher for listener isElementSelected r=dburns
Attachment #8651061 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Bug 1197146: Part 5: Use dispatcher for listener getElementLocation r=dburns
Attachment #8651062 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Bug 1197146: Part 6: Use dispatcher for listener clearElement r=dburns
Attachment #8651063 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Bug 1197146: Part 7: Use dispatcher for listener isElementDisplayed r=dburns
Attachment #8651064 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 9•9 years ago
|
||
Bug 1197146: Part 8: Use dispatcher for listener getElementValueOfCssProperty r=dburns
Attachment #8651065 -
Flags: review?(dburns)
|
|
Assignee | |
Updated•9 years ago
|
Keywords: ateam-marionette-server
|
||
Updated•9 years ago
|
Attachment #8651058 -
Flags: review?(dburns) → review+
|
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8651058 [details] MozReview Request: Bug 1197146: Part 1: Prime dispatcher in listener to resolve promises https://reviewboard.mozilla.org/r/16833/#review15065 Ship It!
|
|
||
Comment 11•9 years ago
|
||
Comment on attachment 8651059 [details] MozReview Request: Bug 1197146: Part 2: Use dispatcher for listener findElementsContent https://reviewboard.mozilla.org/r/16835/#review15067 Ship It!
Attachment #8651059 -
Flags: review?(dburns) → review+
|
|
||
Comment 12•9 years ago
|
||
Comment on attachment 8651060 [details] MozReview Request: Bug 1197146: Part 3: Use dispatcher for listener findElementContent https://reviewboard.mozilla.org/r/16837/#review15069 Ship It!
Attachment #8651060 -
Flags: review?(dburns) → review+
|
|
||
Comment 13•9 years ago
|
||
Comment on attachment 8651061 [details] MozReview Request: Bug 1197146: Part 4: Use dispatcher for listener isElementSelected https://reviewboard.mozilla.org/r/16839/#review15071 Ship It!
Attachment #8651061 -
Flags: review?(dburns) → review+
|
|
||
Comment 14•9 years ago
|
||
Comment on attachment 8651062 [details] MozReview Request: Bug 1197146: Part 5: Use dispatcher for listener getElementLocation https://reviewboard.mozilla.org/r/16841/#review15073 Ship It!
Attachment #8651062 -
Flags: review?(dburns) → review+
|
|
||
Comment 15•9 years ago
|
||
Comment on attachment 8651063 [details] MozReview Request: Bug 1197146: Part 6: Use dispatcher for listener clearElement https://reviewboard.mozilla.org/r/16843/#review15075 Ship It!
Attachment #8651063 -
Flags: review?(dburns) → review+
|
|
||
Comment 16•9 years ago
|
||
Comment on attachment 8651064 [details] MozReview Request: Bug 1197146: Part 7: Use dispatcher for listener isElementDisplayed https://reviewboard.mozilla.org/r/16845/#review15077 Ship It!
Attachment #8651064 -
Flags: review?(dburns) → review+
|
|
||
Comment 17•9 years ago
|
||
Comment on attachment 8651065 [details] MozReview Request: Bug 1197146: Part 8: Use dispatcher for listener getElementValueOfCssProperty https://reviewboard.mozilla.org/r/16847/#review15079 Ship It!
Attachment #8651065 -
Flags: review?(dburns) → review+
|
||
Comment 18•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e582796c14f https://hg.mozilla.org/integration/mozilla-inbound/rev/dda01c42607b https://hg.mozilla.org/integration/mozilla-inbound/rev/6517558635f0 https://hg.mozilla.org/integration/mozilla-inbound/rev/673255adf942 https://hg.mozilla.org/integration/mozilla-inbound/rev/031cdb1945f6 https://hg.mozilla.org/integration/mozilla-inbound/rev/2775f73389e7 https://hg.mozilla.org/integration/mozilla-inbound/rev/550872c7e38a https://hg.mozilla.org/integration/mozilla-inbound/rev/12e2ea054a03
|
||
Comment 19•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1e582796c14f https://hg.mozilla.org/mozilla-central/rev/dda01c42607b https://hg.mozilla.org/mozilla-central/rev/6517558635f0 https://hg.mozilla.org/mozilla-central/rev/673255adf942 https://hg.mozilla.org/mozilla-central/rev/031cdb1945f6 https://hg.mozilla.org/mozilla-central/rev/2775f73389e7 https://hg.mozilla.org/mozilla-central/rev/550872c7e38a https://hg.mozilla.org/mozilla-central/rev/12e2ea054a03
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
|
||
Updated•9 years ago
|
Flags: needinfo?(ryanvm)
|
|
||
Comment 21•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e4069d54d4b1 https://hg.mozilla.org/releases/mozilla-aurora/rev/463f3471e857 https://hg.mozilla.org/releases/mozilla-aurora/rev/f71ee054aab4 https://hg.mozilla.org/releases/mozilla-aurora/rev/6e0802b05f7b https://hg.mozilla.org/releases/mozilla-aurora/rev/62fa60029584 https://hg.mozilla.org/releases/mozilla-aurora/rev/33d9c59ab315 https://hg.mozilla.org/releases/mozilla-aurora/rev/9aec50a751b3 https://hg.mozilla.org/releases/mozilla-aurora/rev/95ea1b781b0f
status-firefox42:
--- → fixed
|
|
||
Comment 22•9 years ago
|
||
Had to back this one out for Marionette test_selected.py failures. https://treeherder.mozilla.org/logviewer.html#?job_id=1072517&repo=mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/66e9b94c4066
Flags: needinfo?(ato)
|
|
Assignee | |
Comment 23•9 years ago
|
||
This probably needs http://hg.mozilla.org/integration/mozilla-inbound/rev/ba43a48d3c52 (bug 1191432) uplifted as well to work.
Flags: needinfo?(ato)
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•