Closed Bug 1197185 Opened 8 years ago Closed 8 years ago

Give NonE10s a virtual destructor

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Give NonE10s a virtual destructor
1.47 KB, patch
jesup
: review+
Details | Diff | Splinter Review 
The Parent template class inherits from both NonE10s and PMediaParent,
and the latter has a virtual destructor.  This confuses clang-tidy when
it wants to rewrite ~Parent() which is currently marked as virtual, and
it makes ~Parent() override which breaks the build since ~NonE10s() is
not virtual.  The easiest way to work around this seems to be making
~NonE10s() virtual.  See the discussion in
https://llvm.org/bugs/show_bug.cgi?id=24496 as well.

        Attachment #8651001 -
        Flags: review?(cpearce)

    
  
Assignee: nobody → ehsan
Blocks: 1158776

    
    

    
  
Comment on attachment 8651001 [details] [diff] [review]
Give NonE10s a virtual destructor

Review of attachment 8651001 [details] [diff] [review]:
-----------------------------------------------------------------

This is webrtc code, so jesup should review it.

        Attachment #8651001 -
        Flags: review?(cpearce) → review?(rjesup)

        Attachment #8651001 -
        Flags: review?(rjesup) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ee7879fae953
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox43:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

          You need to log in
          before you can comment on or make changes to this bug.