Closed Bug 1197202 Opened 9 years ago Closed 7 years ago

Event listeners popup is broken by feature "move event listeners popup with all markup-view when it's being scrolled"

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox43 affected, firefox44 affected, firefox45 affected, firefox46 affected, firefox47 affected)

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox43 --- affected
firefox44 --- affected
firefox45 --- affected
firefox46 --- affected
firefox47 --- affected

People

(Reporter: arni2033, Assigned: miker)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

2016.01.30 03-53-41.png
22.37 KB, image/png
Details
Attached image 2015.08.21 16-52-04.png (obsolete) — 
STR:
1. Open   data:text/html,<body onclick><script>var str='<div>';for(i=0;i<70;i++) str='<span>'+str;document.body.innerHTML=str;</script>
2. Open devtools-Inspector, type "div" in the field "Search with css selectors"
3. Type "body" in the field "Search with css selectors"
4. Click (ev) button next to <body>
5. Scroll markup-view down (by scrolling mousewheel down)

Result:       Popup overlaps content area and toolbars
Expectations: Popup should disappear if the element isn't visible

Note:         I believe that other popups in devtools act the same way
Has STR: --- → yes
Oh, I completely forgot to say that it may break event listeners tooltip!!! 

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160129030206
STR:
0.  Set mouse option "when I rotate mouse wheel" in your OS to "scroll by 1 page"
    Set dark devtools theme
1.  Open the following "data:" url or click URL in the form above
> data:text/html,<body onclick><script>var str='';for(i=70;i>0;i--) str+='<meta i="'+i+'">'; document.head.innerHTML=str;</script>
2.  Switch firefox in fullscreen mode (F11)
3.  Open devtools-> Inspector, expand <body> element im markup-view.
4.  Dock toolbox to the bottom side of window.
5.  Resize toolbox so that only 6-7 lines were visible in markup-view. Scroll markup to the very end.
6.  Resize devtools so that <meta i="11"> was fully visible and <meta i="12"> was outside of viewport
7.  Scroll markup to the very end, make sure <meta i="11"> is fully visible and <meta i="12"> is not
8.  Click (ev) button near <br i="2">
9.  Click the event listener header in the popup opened in Step 8.
10. Scroll markup to the up once (rotate of mouse wheel once)
11. Hover mouse over any visible <br> in markup to let the popup move to its new position, wait 3s.
12. Scroll markup to the very end
13. Click (ev) button near <br i="2">
14. Click (ev) button near <br i="2">

AR:  Event listeners popup is 0px in height. Can't observe any event listener.
ER:  Either A or B
 A) The popup should move with markup and stay visible, even if the node is not visible, but
    popup should keep normal height
 B) The popup should disappear when connected node leaves the viewport (in markup-view)

Note: this is only the most reliable STR. Of course it's ACCIDENTALLY reproducible with other
      html pages and with mouse option "when I rotate mouse wheel" set to "scroll by N lines"
> screencast:   https://dl.dropboxusercontent.com/s/dpsxcbtnjykvir0/bug%201197202%20comment%201.webm
URL: data:text/html,<body><script>var str=...
status-firefox44: --- → affected
status-firefox45: --- → affected
status-firefox46: --- → affected
status-firefox47: --- → affected
Summary: Event listeners popups is moved with all markup-view when you scroll it (even if the element isn't visible) → Event listeners popup is broken by feature "move event listeners popup with all markup-view when it's being scrolled"
Attached image 2016.01.30 03-53-41.png — 

        Attachment #8651023 -
        Attachment is obsolete: true

    
    

    
  
From what I tested on OSX and Windows, the "move popup with scroll" feature rarely works as intended. When it moves the popup, it does so with a huge delay and it also often misses the anchor.

I'm going to block this on the HTML refactor of the event listeners tooltip. However I think in a first implementation, we should simply hide the tooltip when the anchor's container is scrolled. 

Inspector bug triage. Filter on CLIMBING SHOES.
Depends on: 1266450
Priority: -- → P3

    
    

    
  
This has been fixed... we basically don't move the tooltip with the node, which is preferable to hiding it because you may still want to see the popup contents.

@arni2033: Can you test with the latest nightly and let me know whether we can close this bug?
Assignee: nobody → mratcliffe
Flags: needinfo?(arni2033)

    
    

    
  
I can't test any version later than 2016-05-26 due to bad internet connection, but I remember testing this on Nightly 2016-10-01, and XUL panel was replaced with a broken (bug 1279400) HTML replacement
The HTML replacement didn't move the tooltip, so this bug wasn't reproducible.

If it's still the case on Nightly and if you already pushed the broken HTML replacement to release version, then this bug can't possibly happen. Set NI again if you want me to test the latest Nightly
when I get back my internet connection.
Flags: needinfo?(arni2033)

    
    

    
  
As mentioned by comment 4 we are no longer moving the popup.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: