Switch to MLS in Firefox beta & release

RESOLVED FIXED in mozilla44

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: garvan, Assigned: garvan)

Tracking

({dev-doc-needed, meta})

unspecified
mozilla44
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 wontfix, firefox42+ wontfix, firefox43+ disabled, firefox44+ disabled, firefox45+ disabled)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1122393#c4

1) geo.wifi.uri should always point to location.services.mozilla.com and 
2) geo.provider.use_corelocation should always be enabled, independent of the channel.
Assignee

Comment 1

4 years ago
Preparing this patch ahead of time, so when the switch is made, it can be landed.
Attachment #8651029 - Flags: review?(hschlichting)

Comment 2

4 years ago
Comment on attachment 8651029 [details] [diff] [review]
bug1197211.diff

Review of attachment 8651029 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!
Attachment #8651029 - Flags: review?(hschlichting) → review+
Tracking as it might land in 42.
[Tracking Requested - why for this release]: As mentioned in Bug 1121862, this was going to happen in 42, but got lost in the confusion. This just turns off the mechanism we've been using to disable.
Depends on: 1121862
Sounds like this should land in nightly. Then, please request uplift to aurora. Thanks!
Flags: needinfo?(telliott)
Flags: needinfo?(garvankeeley+bmo)
This has been in Aurora since 38.
Flags: needinfo?(telliott)
this patch still needs to land in mozilla-central.

Do we need to also add in logic to serve the old (google) api for location to older versions of Firefox? (Important to not break location services for 42 and older, also keeping ESR users in mind. )
Oh wait. That would just work (from those older versions since they're still pointing at google) So this patch should do it. Great. Let's land it in m-c and then uplift
checkin-needed for mozilla-inbound
Flags: needinfo?(garvankeeley+bmo)
Keywords: checkin-needed
We will ship that with 43 and we want to add this to the release notes

Release Note Request (optional, but appreciated)
[Why is this notable]: New great changes
[Suggested wording]: Switch to Mozilla Location Services
[Links (documentation, blog post, etc)]: we should prepare a blog post.
Comment on attachment 8651029 [details] [diff] [review]
bug1197211.diff

Approval Request Comment
[User impact if declined]: None. The change is already in Aurora; this update lets it ride the train into beta.
Attachment #8651029 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/070ec86ea515
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8651029 [details] [diff] [review]
bug1197211.diff

Approved for uplift to aurora.
Attachment #8651029 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Toby, will you write a post about this at some point before release? If not you, who should do it, and can you needinfo them or let them know? Thanks!
Flags: needinfo?(telliott)
what's the audience? Is this an internal one, or the external blog? I'm happy to write it.

Presumably, we want this for beta, which is where the change occurs now?
Flags: needinfo?(telliott)
Yes, for beta 43, which should be released November 2, and for general Firefox users (i.e. external). I'm not sure where you want to write about it, but somewhere on a mozilla.org site is best (rather than a personal blog)
Great. Will do. Working with the PR team on this. Thanks!
Needinfoing myself as a reminder to add the release note for this for beta 43 (since this is in 43, but not enabled till 43 hits beta)
Flags: needinfo?(lhenry)
I think the last clause ("as soon as 43 hits Firefox Beta") is a bit misleading, as it's already doing so in 43 Aurora. Otherwise, looks correct.
(In reply to Toby Elliott [:telliott] from comment #22)
> I think the last clause ("as soon as 43 hits Firefox Beta") is a bit
> misleading, as it's already doing so in 43 Aurora. Otherwise, looks correct.

ok; removed that last clause.
Quick note on this. PR and marketing are planning to make mention of this during 43 Release on the Firefox blog post. We will likely stay clear of calling out Google and just make mention of the fact that we are now using MLS + benefits. 

For the release note, great if we can keep it about MLS. Proposed:

Firefox now uses Mozilla Location Services (MLS) when determining location at user's request
Fabio, depending on how much you plan to elaborate on MLS's benefits, you might consider working with our geolocation partner Combain to cross-promote each others' services. :)

https://blog.mozilla.org/services/2015/03/06/combain-deal-helps-expand-mozilla-location-service/
(In reply to Fabio Rios [:frios] from comment #24)
> Quick note on this. PR and marketing are planning to make mention of this
> during 43 Release on the Firefox blog post. We will likely stay clear of
> calling out Google and just make mention of the fact that we are now using
> MLS + benefits. 
> 
> For the release note, great if we can keep it about MLS. Proposed:
> 
> Firefox now uses Mozilla Location Services (MLS) when determining location
> at user's request

Ok, I've removed the bit about GLS.
Summary: Switch to MLS: required changes to firefox.js profile → Switch to MLS in Firefox beta & release
(In reply to Chris Peterson [:cpeterson] from comment #25)
> Fabio, depending on how much you plan to elaborate on MLS's benefits, you
> might consider working with our geolocation partner Combain to cross-promote
> each others' services. :)
> 
> https://blog.mozilla.org/services/2015/03/06/combain-deal-helps-expand-
> mozilla-location-service/

Ah, that's helpful. I need to look into this a bit more -- around how and why we use a backup. Thanks Chris

In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #26)
> (In reply to Fabio Rios [:frios] from comment #24)
> > Quick note on this. PR and marketing are planning to make mention of this
> > during 43 Release on the Firefox blog post. We will likely stay clear of
> > calling out Google and just make mention of the fact that we are now using
> > MLS + benefits. 
> > 
> > For the release note, great if we can keep it about MLS. Proposed:
> > 
> > Firefox now uses Mozilla Location Services (MLS) when determining location
> > at user's request
> 
> Ok, I've removed the bit about GLS.

Thank you!
Depends on: 1216662
Not adding release note since our plans have changed for 43 and MLS.
Flags: needinfo?(lhenry)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #28)
> Not adding release note since our plans have changed for 43 and MLS.

Does this affect the MDN release notes too:

https://developer.mozilla.org/en-US/Firefox/Releases/43#Other

Do I need to remove this? Thanks!
Flags: needinfo?(lhenry)
Yes. Now that we have successfully removed the code, we need to pull that release note as well. Thanks!
Flags: needinfo?(lhenry)
(In reply to Toby Elliott [:telliott] from comment #30)
> Yes. Now that we have successfully removed the code, we need to pull that
> release note as well. Thanks!

Ok - removed!
Marking this as "disabled" for 43 and 44. 

Where is the bug where we actually turned this off? Thanks.
Flags: needinfo?(telliott)
That was Bug 1216662
Flags: needinfo?(telliott)
Toby, do you have an idea when we are planning to ship that? Thanks
Flags: needinfo?(telliott)
We currently don't have any concrete plans to switch away from Google for beta/release builds. The plans we had where put on hold.
Flags: needinfo?(telliott)
To be more explicit: barring a change in other Geolocation priorities surrounding IoT and FFOS, this is unlikely to happen in the forseeable future.
This makes me sad but ok, thanks for the feedback.
We are not going to ship this soon, removing the relnotes flag to clear our radar.
Please resubmit when we plan to ship it.
relnote-firefox: ? → ---

Updated

3 years ago
Group: mozilla-employee-confidential
You need to log in before you can comment on or make changes to this bug.