Closed Bug 1197215 Opened 8 years ago Closed 8 years ago

Predictor.cpp: remove some useless declarations

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1314957])

Attachments

(1 file)

bug-1197215.diff
1.05 KB, patch
u408661
: review+
Details | Diff | Splinter Review 
in Predictor::SpaceCleaner::OnMetaDataElement(const char *key, const char *value)

ok is useless and just adds confusion in the method
Attached patch bug-1197215.diff — — Splinter Review 

        Attachment #8651033 -
        Flags: review?(nfroyd)

    
    

    
  
Comment on attachment 8651033 [details] [diff] [review]
bug-1197215.diff

Review of attachment 8651033 [details] [diff] [review]:
-----------------------------------------------------------------

I'll r+ this, since froydnj isn't a necko peer :)

However, I will take issue with the proposed commit message - the declaration (and earlier use) of |ok| is nowhere close to useless. It's just that these later uses of |ok| have been obsoleted by the earlier use (which was added well after these original uses were in the tree). Probably something like:

    Bug 1197215 - Remove now unnecessary uses of ok in the predictor. r=hurley

Sound good?

        Attachment #8651033 -
        Flags: review?(nfroyd) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4c14cdd926f9
Assignee: nobody → sledru
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox43:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

          You need to log in
          before you can comment on or make changes to this bug.