Predictor.cpp: remove some useless declarations

RESOLVED FIXED in Firefox 43

Status

()

Core
Networking
RESOLVED FIXED
3 years ago
14 days ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla43
coverity
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

(Whiteboard: [CID 1314957])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
in Predictor::SpaceCleaner::OnMetaDataElement(const char *key, const char *value)

ok is useless and just adds confusion in the method
(Assignee)

Comment 1

3 years ago
Created attachment 8651033 [details] [diff] [review]
bug-1197215.diff
Attachment #8651033 - Flags: review?(nfroyd)
Comment on attachment 8651033 [details] [diff] [review]
bug-1197215.diff

Review of attachment 8651033 [details] [diff] [review]:
-----------------------------------------------------------------

I'll r+ this, since froydnj isn't a necko peer :)

However, I will take issue with the proposed commit message - the declaration (and earlier use) of |ok| is nowhere close to useless. It's just that these later uses of |ok| have been obsoleted by the earlier use (which was added well after these original uses were in the tree). Probably something like:

    Bug 1197215 - Remove now unnecessary uses of ok in the predictor. r=hurley

Sound good?
Attachment #8651033 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/4c14cdd926f9
Assignee: nobody → sledru
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
(Assignee)

Updated

14 days ago
Blocks: 1230156
You need to log in before you can comment on or make changes to this bug.