Closed Bug 1197215 Opened 4 years ago Closed 4 years ago

Predictor.cpp: remove some useless declarations

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1314957])

Attachments

(1 file)

in Predictor::SpaceCleaner::OnMetaDataElement(const char *key, const char *value)

ok is useless and just adds confusion in the method
Attached patch bug-1197215.diffSplinter Review
Attachment #8651033 - Flags: review?(nfroyd)
Comment on attachment 8651033 [details] [diff] [review]
bug-1197215.diff

Review of attachment 8651033 [details] [diff] [review]:
-----------------------------------------------------------------

I'll r+ this, since froydnj isn't a necko peer :)

However, I will take issue with the proposed commit message - the declaration (and earlier use) of |ok| is nowhere close to useless. It's just that these later uses of |ok| have been obsoleted by the earlier use (which was added well after these original uses were in the tree). Probably something like:

    Bug 1197215 - Remove now unnecessary uses of ok in the predictor. r=hurley

Sound good?
Attachment #8651033 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/4c14cdd926f9
Assignee: nobody → sledru
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.