1197305 - [raptor] reboot test intermittent failure 'missing initial entry'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[Robert Wood [:rwood]]

The Raptor reboot test is failing intermittently on flame with this error:

Error: Missing initial entry mark for run
    at Phase.format (/home/rwood/raptor/lib/phases/phase.js:411:24)
    at Reboot.handleRun (/home/rwood/raptor/lib/phases/reboot.js:192:27)
    at /home/rwood/raptor/lib/phases/phase.js:279:20
    at /home/rwood/raptor/node_modules/promise/lib/core.js:33:15
    at flush (/home/rwood/raptor/node_modules/promise/node_modules/asap/asap.js:27:13)
    at process._tickCallback (node.js:355:11)

Full log with extra debugging here:
https://gist.github.com/rwood-moz/48e7837d3f3cdb71cf12

I suspect there is a race condition where the 'deviceReboot' mark entry is written and actually received in the log before the log parser/handler is ready. So when the parser/handler is ready, the start mark has already gone by, and so the first entry received is `gecko-shell-html-load`, not the start mark. Perhaps the parser should be registered and the capture listener initialied before writing the start mark (?) however would this skew the timing results?

Comment 1

[Robert Wood [:rwood]]

Attachment: https://github.com/mozilla-raptor/raptor-cli/pull/35

The problem was we were rebooting the device, posting the performance reboot marker, then turning on the handlers after that. Most times that was fine, but intermittently the handler wouldn't be enabled fast enough and the deviceReboot marker had already gone by. Enabling the handlers first before posting the reboot marker seems to fix the problem, at least in all the tests I've done thus far.

This change won't alter the reboot results because the time of the actual reboot is not changed, and the rebootDevice marker still uses the same value from phase._restart().

Comment 2

[:Eli Perelman]

Comment on attachment 8679605 [details] [review]
https://github.com/mozilla-raptor/raptor-cli/pull/35

FINALLY!

Comment 3

[Robert Wood [:rwood]]

Thanks, landed:

https://github.com/mozilla-raptor/raptor-cli/commit/e823365cb1167a1b14ac395238fa2d634de2e547

Comment 4

[Robert Wood [:rwood]]

+ @mozilla/raptor@3.2.1 published