pushPrefEnv/popPrefEnv/flushPrefEnv should return a promise

RESOLVED FIXED in Firefox 49

Status

Testing
Mochitest
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bgrins, Assigned: MattN)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
It would be nice for tests using pushPrefEnv if it returned a Promise.  We could keep the callback but make it optional, and then return a Promise that is resolved at the same time the callback is fired.
Created attachment 8752432 [details]
MozReview Request: Bug 1197310 - Return a promise from pushPrefEnv/popPrefEnv/flushPrefEnv. r=jmaher

Review commit: https://reviewboard.mozilla.org/r/52615/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52615/
Attachment #8752432 - Flags: review?(jmaher)
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Comment on attachment 8752432 [details]
MozReview Request: Bug 1197310 - Return a promise from pushPrefEnv/popPrefEnv/flushPrefEnv. r=jmaher

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52615/diff/1-2/
Comment on attachment 8752432 [details]
MozReview Request: Bug 1197310 - Return a promise from pushPrefEnv/popPrefEnv/flushPrefEnv. r=jmaher

https://reviewboard.mozilla.org/r/52615/#review49561

thanks for this cleanup- please test on try for all platforms!
Attachment #8752432 - Flags: review?(jmaher) → review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8d9be6d52d27
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.