1197324 - add format-string checking attribute to snprintf_literal

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Nathan Froyd [:froydnj]]

As we start to use snprintf_literal more widely, it would be good to have format string checking enabled for it, so we don't do stupid things with it.

Comment 1

[Tom S [:evilpie]]

Attachment: Format string checking for snprintf_literal

I wasn't sure if this should go into mozilla/Attributes.h so I just did the simple thing here.

Comment 2

[Tom S [:evilpie]]

Attachment: Fix new -WFormat warnings

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8777088 [details] [diff] [review]
Format string checking for snprintf_literal

Review of attachment 8777088 [details] [diff] [review]:
-----------------------------------------------------------------

I doubt we have many cases for __attribute__((format)), so this is fine.

::: mfbt/Snprintf.h
@@ +17,5 @@
>  // function which uses template argument deduction to deduce the size of the
>  // buffer, avoiding the need for the user to pass it in explicitly.
>  #ifdef __cplusplus
>  template <size_t N>
> +#if defined(__GNUC__) || defined(__clang__)

FWIW, clang defines __GNUC__, so you are good to drop the __clang__ here.

Comment 4

[Tom S [:evilpie]]

Comment on attachment 8777118 [details] [diff] [review]
Fix new -WFormat warnings

Would you be ok with reviewing this? Otherwise I probably need three reviewers.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b04df0234b5
add format-string checking attribute to snprintf_literal. r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7261f08cce
Fix new warnings. r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b04df0234b5
https://hg.mozilla.org/mozilla-central/rev/4b7261f08cce