1197373 - Imagecompare: add wait after scroll in calendar until the scroll bar disappears

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

Scroll bar shows right after the scroll action, and it disappears in 1-2 seconds.  need to wait so the screen capture does not capture the scrollbar.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1197373 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

Comment on attachment 8651341 [details] [review]
[gaia] npark-mozilla:1197373 > mozilla-b2g:master

So the calendar app shows the scroll bar during scroll action, and it disappears after the motion has stopped.  It takes about half a second for it to disappear, so I'm adding a manual wait of 1 second. (3 second for the first one, since that transition seems to take longer)

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8651341 [details] [review]
[gaia] npark-mozilla:1197373 > mozilla-b2g:master

Why wasn't this a problem before with this test? Or it was actually?
I thought the idea was to prevent time.sleep calls as much as possible (something that should be/is in our style guide?), but I guess there is no way of detecting scrollbar disappearance.

Comment 4

[No-Jun Park [:njpark]]

This was failing intermittently, but recently this became noticeable, so I decided to fix it for good.  I was looking for the scrollbar element, but I don't think we can see it in the source.

Comment 5

[No-Jun Park [:njpark]]

merged:

https://github.com/mozilla-b2g/gaia/commit/b441bde54293bea5254dc340845effe951fa3906