Imagecompare: remove unnecessary self.email.wait_for_search_textbox_hidden() call

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njpark, Assigned: njpark)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Checking for an element to be not visible sometimes fails on occasion, and upon close inspection, it seems that we do not need this call in test_setup_and_send_receive_imap_email.py
(Assignee)

Updated

2 years ago
Assignee: nobody → npark
No longer depends on: 1197373
Yes, something has changed lately that causes these checks_for_not_visible anymore to fail occasionally.
I noticed the same thing in bug 1196866, comment 3. I suspect we need to revisit all of these expected.element_not_displayed checks.
Created attachment 8651881 [details] [review]
[gaia] npark-mozilla:1197468 > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Attachment #8651881 - Flags: review?(martijn.martijn)
Comment on attachment 8651881 [details] [review]
[gaia] npark-mozilla:1197468 > mozilla-b2g:master

Shouldn't it also be removed here then? http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/email/test_setup_and_send_imap_email.py#69
And then the whole function is not used anymore.
Attachment #8651881 - Flags: review?(martijn.martijn) → review+
(Assignee)

Comment 4

2 years ago
It does get hidden when a new email arrives, but wait_for_email() method already waits enough so I can tap on it.  So it is a useful check, but not in my case.  Let's see whether above script fails intermittently as well, then perhaps we could think about removing it here as well.
(Assignee)

Comment 5

2 years ago
Merged:

https://github.com/mozilla-b2g/gaia/commit/97cb6736d0f2f637ebd7dd21683ff7fa670c2507
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
But why was it failing then in your case? I would think it would also fail in regular Gaia UI test then.
(Assignee)

Comment 7

2 years ago
I think so too, but oddly I haven't seen reports of it failing on test_setup_and_send_imap_email.py. Only error regarding this script is https://bugzilla.mozilla.org/show_bug.cgi?id=1172477, and it's when the email actually did not get sent.
You need to log in before you can comment on or make changes to this bug.