Closed
Bug 1197563
Opened 10 years ago
Closed 10 years ago
Polyfill __func__ for MSVC 2013 and earlier
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
7.49 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
__func__ was standardized in C++11 and is supported by clang, gcc, and MSVC 2015. __func__ has been polyfilled in multiple locations in the tree for earlier versions of MSVC. This patch consolidates the multiple definitions into one.
http://blogs.msdn.com/b/vcblog/archive/2015/06/19/c-11-14-17-features-in-vs-2015-rtm.aspx
Green try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b130a9a43b38
Attachment #8651472 -
Flags: review?(nfroyd)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8651472 [details] [diff] [review]
polyfill-__func__.patch
Review of attachment 8651472 [details] [diff] [review]:
-----------------------------------------------------------------
I was thinking that we would have a polyfill header in MFBT for this, but I guess putting it with the logging code makes about as much sense as anything...
Attachment #8651472 -
Flags: review?(nfroyd) → review+
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•