Closed Bug 1197563 Opened 7 years ago Closed 7 years ago

Polyfill __func__ for MSVC 2013 and earlier

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

__func__ was standardized in C++11 and is supported by clang, gcc, and MSVC 2015. __func__ has been polyfilled in multiple locations in the tree for earlier versions of MSVC. This patch consolidates the multiple definitions into one.

http://blogs.msdn.com/b/vcblog/archive/2015/06/19/c-11-14-17-features-in-vs-2015-rtm.aspx

Green try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b130a9a43b38
Attachment #8651472 - Flags: review?(nfroyd)
Comment on attachment 8651472 [details] [diff] [review]
polyfill-__func__.patch

Review of attachment 8651472 [details] [diff] [review]:
-----------------------------------------------------------------

I was thinking that we would have a polyfill header in MFBT for this, but I guess putting it with the logging code makes about as much sense as anything...
Attachment #8651472 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/61993e366ce6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Depends on: 1288924
You need to log in before you can comment on or make changes to this bug.