1197568 - create a main.Application class

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

The bisector.BisectRunner is not really well named. I propose to move that code in a new Application class, where it will make more sense.

Application will be the entry point to run the bisection (after the command line arguments have been parsed and verified). It will be also useful when we will want to implement the --launch argument.

Comment 1

[Julien Pagès (:parkouss)]

Oups, I did not meant to close it.

Comment 2

[Julien Pagès (:parkouss)]

Attachment: create a main.Application class

Again, a big change! Sorry for that, but this is time for some good refactoring in mozregression. :)

Well, this will also help to implement the --launch feature in a nice and clean way.

Copy paste of the commit comment:

Replace the bisector.BisectRunner class with a main.Application class.

The purpose of this class is a bit more generic though it can still run
nightlies and inbounds bisection. Application is reponsible to create and
manage the required instances of BuildDownloadManager, TestRunner and Bisector.
It also create a temporary download dir if no persist dir is given.

Comment 3

[MikeLing]

Comment on attachment 8651685 [details] [review]
create a main.Application class

Just test it on locally, I think it's good to go :)

Comment 4

[Julien Pagès (:parkouss)]

Thanks MikeLing!

So this is a great change I think (and I want to go on hacking with some things that needs that), so I decided to land in https://github.com/mozilla/mozregression/commit/2d123ccb1704e1c9248d851c3fc8117cc6e1363b.

Will, feel tree to give some feedback, I will take it in consideration of course and could address issues in follow-ups.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8651685 [details] [review]
create a main.Application class

If :mikeling looked over it, I think that's good enough for a review. :)