Created attachment 8651496 [details] [diff] [review] bug-1197585-tablewidget-warnings.patch Here's a patch that fixes the warnings by introducing the required theme sheet and class to the test document. With this patch the times are following : * browser_tableWidget_basic.js: 1555ms * browser_tableWidget_keyboard_interaction.js: 1239ms * browser_tableWidget_mouse_interaction.js: 1336ms Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=63ae08917a29  http://email@example.com/try-linux/try_ubuntu32_vm_test-mochitest-devtools-chrome-2-bm03-tests1-linux32-build36.txt.gz
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8651496 - Flags: review?(bgrinstead)
Comment on attachment 8651496 [details] [diff] [review] bug-1197585-tablewidget-warnings.patch Review of attachment 8651496 [details] [diff] [review]: ----------------------------------------------------------------- Good catch - thanks for the patch! Relatedly, we should profile why it's that slow to print all those messages. That's even without the browser console opened, so it might be a good way to capture backend slowness
Attachment #8651496 - Flags: review?(bgrinstead) → review+
Took a quick profile and 42% of the total time is spent in Tester.onConsoleMessage()  (self cost 8%) and most of that is spent in StructuredLogger._dumpMessage() (self cost 31%) . So it's not the backend that is slow, it's just the dumping which is expensive.  https://dxr.mozilla.org/mozilla-central/rev/ba43a48d3c528cc956335793e02504e5ca2c149f/testing/mochitest/browser-test.js#400  https://dxr.mozilla.org/mozilla-central/rev/ba43a48d3c528cc956335793e02504e5ca2c149f/testing/mochitest/tests/SimpleTest/TestRunner.js#266
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
(In reply to Sami Jaktholm from comment #4) > Took a quick profile and 42% of the total time is spent in > Tester.onConsoleMessage()  (self cost 8%) and most of that is spent in > StructuredLogger._dumpMessage() (self cost 31%) . > > So it's not the backend that is slow, it's just the dumping which is > expensive. > >  > https://dxr.mozilla.org/mozilla-central/rev/ > ba43a48d3c528cc956335793e02504e5ca2c149f/testing/mochitest/browser-test. > js#400 >  > https://dxr.mozilla.org/mozilla-central/rev/ > ba43a48d3c528cc956335793e02504e5ca2c149f/testing/mochitest/tests/SimpleTest/ > TestRunner.js#266 Ah, good to know - thanks!
You need to log in before you can comment on or make changes to this bug.