APZAllowZooming pref is not consistently applied

RESOLVED FIXED in Firefox 43

Status

()

Core
Panning and Zooming
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8651505 [details] [diff] [review]
Patch

In bug 1186004 I added an apz.allow_zooming pref and in bug 1187792 I made it so that the SPCSPS was not set on platforms where apz.allow_zooming is false. However I only guarded the callsite in APZCCallbackHelper and not the callsite in MobileViewportManager which I now think should be guarded as well. In particular, I want this to make the tests pass with the rest of my fixes for bug 1180267.
Created attachment 8651750 [details] [diff] [review]
Patch

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=df560bf8cef6 includes this patch.
Attachment #8651505 - Attachment is obsolete: true
Attachment #8651750 - Flags: review?(botond)

Updated

3 years ago
Attachment #8651750 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/44ffa68bc9d7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.