1197624 - Bookmarks toolbarbutton doesn't have dropmarker when toolbar is in "overflow" mode

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[arni2033]

Attachment: Release40 - Bookmarks button has no dropmarker.png

STR:   (Win7, Nightly 43.0a1 (2015-08-20))
1. Place Bookmarks button button on toolbar.
2. Dock the window to the left side of screen, place mouse over right border of the window and drag it to the left to make window's width as small as possible (to cause overflow)
3. Click #nav-bar-overflow-button to view hidden buttons in toolbar

Result:       Bookmarks button has no dropmarker.
Expectations: Bookmarks button has a dropmarker, like it used to.

Comment 1

[arni2033]

Attachment: ESR38 - Bookmarks button has 'dropmarker'.png

Comment 2

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=62478b47bc14&tochange=87f15ce8266d

Regressed by:
87f15ce8266d	Dão Gottwald — Bug 1147702 - Use a @2x Toolbar.png on Windows for basic hidpi support. r=MattN

Comment 4

[atlanto]

I can see this issue on Windows10, but not on Linux.
This is caused by
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/customizableui/panelUIOverlay.css#87
>.widget-overflow-list .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
>  padding: 0 6px;
>}
(introduced with bug 916953 fix)
and
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#686
>#bookmarks-menu-button[cui-areatype="toolbar"] > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
>  max-width: 18px;
>}
(originally introduced with bug 1147702 fix)
These styles result 18-(6*2)=6px size icon...

For about the toolbar(navigation bar), there is another style.
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#752
>#nav-bar #bookmarks-menu-button[cui-areatype="toolbar"] > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
>  /* horizontal padding + border + actual icon width */
>  max-width: 32px;
>}

For about Linux not having this issue, there is no "padding: 0 6px".
https://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/customizableui/panelUIOverlay.css

Workarounds with Stylish add-on:
.widget-overflow-list .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
  padding: 0 !important;
}
Or
#bookmarks-menu-button[cui-areatype="toolbar"][overflowedItem=true] > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
  max-width: 32px;
}
Or
#bookmarks-menu-button[cui-areatype="toolbar"] > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
  max-width: 32px !important;
}
Or
?

Comment 7

[magicp]

This is a long outstanding issue. How about next steps ?

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Gijs, do you know who could help with this? Thanks

Comment 9

[:Gijs (he/him)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> Gijs, do you know who could help with this? Thanks

Talking to Dão would be a good first step. I don't have cycles to work on this myself, and he's been needinfo'd here for a while and was also the person who wrote the patch for the regressing bug.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Long time regression, wontfix for 49 at this point. I will email Dão today.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 50 after talking with Dao.

Comment 12

[Gerry Chang [:gchang]]

Mark 51 fix-optional for now but still happy to take the patch in 51 early beta.

Comment 13

[Dão Gottwald [:dao]]

This button has been redesigned so this bug can't happen anymore.