javascript strict warnings in pref-themes.js

VERIFIED FIXED in Future

Status

VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: bugzilla, Assigned: stdowa+bugzilla)

Tracking

({helpwanted})

Trunk
Future
x86
Windows 2000
helpwanted

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

833 bytes, patch
Morten
: review+
hewitt
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
Warning: reference to undefined property gData.loaded
Source File: chrome://communicator/content/pref/pref-themes.js
Line: 58

to reproduce:
just go into Edit -> Prefs -> Apperance -> Themes

build 20020111

Updated

17 years ago
Keywords: helpwanted
Target Milestone: --- → Future
(Reporter)

Comment 1

17 years ago
Warning: reference to undefined property gData.loaded
Source File: chrome://communicator/content/pref/pref-themes.js
Line: 58
Warning: reference to undefined property gData.themeIndex
Source File: chrome://communicator/content/pref/pref-themes.js
Line: 59
20020116
(Assignee)

Comment 2

17 years ago
Created attachment 80299 [details] [diff] [review]
patch
(Assignee)

Comment 3

17 years ago
Created attachment 81100 [details] [diff] [review]
patch v1.1
Attachment #80299 - Attachment is obsolete: true

Comment 4

17 years ago
Comment on attachment 81100 [details] [diff] [review]
patch v1.1

looks good
r=morten@nilsen.com
Attachment #81100 - Flags: review+

Comment 5

17 years ago
Comment on attachment 81100 [details] [diff] [review]
patch v1.1

sr=hewitt
Attachment #81100 - Flags: superreview+
(Reporter)

Comment 6

17 years ago
when I click the themes item in Edit -> Prefs I also see:

Error: uncaught exception: 
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) 
[nsIXULChromeRegistry.isSkinSelected]"  nsresult: "0x80004003 
(NS_ERROR_INVALID_POINTER)"  location: "JS frame :: 
chrome://communicator/content/pref/pref-themes.js :: Startup :: line 76"  data: no]

not 
sure if it's outside the scope of this bug?
(Assignee)

Comment 7

17 years ago
Henrik, that exception should be fixed when the skin in use is actually 
selected, bug 132242.
Assignee: sgehani → walk84
C:\moz_src\mozilla\xpfe\components\prefwindow\resources\content>cvs commit -
m "Bug 119764.  JS strict warnings in pref-themes.js.  Patch by Stephen Walker 
<walk84@yahoo.com> r=morten@nilsen.com/sr=hewitt@netsca
pe.com" pref-themes.js
Checking in pref-themes.js;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-themes.js,v  
<--  pref-themes.js
new revision: 1.33; previous revision: 1.32
done
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
other than what still occurs in comment 6 (covered by bug 132242), i don't see
the strict warnings orginally reported. vrfy'd fixed using 2002.06.17.08 comm
trunk bits on linux rh7.2.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.