Closed Bug 1197646 Opened 4 years ago Closed 4 years ago

GC Markers can collapse strangely

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(3 files)

Uncovered this while doing allocation things, and I think it's recreatable outside of the patch. View attached image. The restyle/paint markers should be between GC markers, except a good chunk of them are collapsed under the last one.
Attached file weird-gc-collapse.json
json recording.
This was a fun one.

Now we sort markers on the client upon completion -- the server side still does for consistency, and we'd change this whenever we do non-realtime markers as well.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d265980af54a
Attachment #8651566 - Flags: review?(vporof)
Comment on attachment 8651566 [details] [diff] [review]
1197646-marker-order.patch

Review of attachment 8651566 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/actors/performance-recording.js
@@ +237,5 @@
>        this._profile = form.profile;
>      }
> +
> +    // Sort again on the client side if we're using realtime markers and the recording
> +    // just finished. This is because GC markers can come into the array out of order with

Not just GC markers, this can happen with anything. For example, Composite markers will have this issue too.
Attachment #8651566 - Flags: review?(vporof) → review+
Duplicate of this bug: 1189628
https://hg.mozilla.org/mozilla-central/rev/7479b25812d1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.