1197667 - B2G NetworkManager: 'allNetworkInfo' implementation missing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Jessica Jong [:jessica] (inactive)]

In bug 1167132, we exposed 'allNetworkInfo' instead of 'networkInterfaces', but I missed the implementation for it :(.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Turns out that only TetheringService is using NetworkManager.allNetworkInfo and it uses a default value if it can not find a proper one, so we didn't catch this issue.

Comment 3

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8651650 [details] [diff] [review]
patch, v1.

Edgar, may I have your review on this? Thanks.

Comment 4

[Jessica Jong [:jessica] (inactive)]

I'll add a test case for this to prevent future mistakes.

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 8651650 [details] [diff] [review]
patch, v1.

Review of attachment 8651650 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but please still provide a test case for allNetworkInfo. Thank you.

Comment 6

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 1: allNetworkInfo implementation. r=echen

Commit message amended.

Comment 7

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 2: allNetworkInfo tests, v1.

Comment 8

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 2: allNetworkInfo tests, v2.

Changes since v1:
- use settings to enable/disable wifi, otherwise wifi test cases using settings will fail afterwards.

Edgar, may I have your review on the test case part? Thanks.

Comment 9

[Edgar Chen [:edgar]]

Comment on attachment 8654743 [details] [diff] [review]
Part 2: allNetworkInfo tests, v2.

Review of attachment 8654743 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 10

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 2: allNetworkInfo tests. r=echen

Sorry Edgar, this should be the correct patch, using settings to enable/disable wifi, else wifi tests will fail. Another thing that I modified, is to restore wifi to its original state.

Would you mind reviewing again? Thanks.

Comment 11

[Jessica Jong [:jessica] (inactive)]

try looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a17d5ca77aa6&group_state=expanded&exclusion_profile=false

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/115f1a4faea6
https://hg.mozilla.org/integration/b2g-inbound/rev/ab2b5214e325

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/115f1a4faea6
https://hg.mozilla.org/mozilla-central/rev/ab2b5214e325