119768 - Remove button in Smart Browsning should be context disabled

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P4)

Description

[Henrik Gemal]

Go into Edit -> Prefs -> Navigator -> Smart Browsing
The Remove button is active even though nothing is highlighted. There's nothing
to remove but still the button is active. The button should only be active is
there's something that can be removed.

build 20020111

Comment 1

[sairuh (rarely reading bugmail)]

->joe

Comment 2

[Samir Gehani]

Attachment: Fix to disable remove button when no domains present in disabled list.

Comment 3

[Joe Hewitt (gone)]

-> samir since he has a patch

Comment 4

[Samir Gehani]

morse, please r.
hewitt, please sr.

Comment 5

[Stephen P. Morse]

Comment on attachment 65331 [details] [diff] [review]
Fix to disable remove button when no domains present in disabled list.

r=morse

Comment 6

[Joe Hewitt (gone)]

Can you change this:
+    removeButton.disabled = "true";
+  else
+    removeButton.removeAttribute("disabled"); 

To this:
+    removeButton.disabled = true;
+  else
+    removeButton.disabled = false;

Comment 7

[Samir Gehani]

Attachment: Patch rev 2 with reviewer changes.

Hewitt,
Could you highlight why setting ``disabled'' to a JS boolean of false is better
than removing the attribute altogether?  And could you sr the change while
you're at it?  Thanks.

Comment 8

[Joe Hewitt (gone)]

Comment on attachment 68409 [details] [diff] [review]
Patch rev 2 with reviewer changes.

sr=hewitt

Comment 9

[Joe Hewitt (gone)]

The disabled property is boolean, so you shouldn't be passing strings like
"true" into it.  This will work for "true", but won't for "false".  Since we
have this propery, and it does the job of removing the attribute, might as well
be symmetrical and conventional and use it consistently.

Comment 10

[Samir Gehani]

Checked in.

Comment 11

[:deanis74]

If I ctrl+click to un-highlight the current selection in the list, shouldn't the
Remove button be disabled?

Comment 12

[Henrik Gemal]

v 20020221