Remove button in Smart Browsning should be context disabled

VERIFIED FIXED in mozilla0.9.9

Status

P4
normal
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: bugzilla, Assigned: samir_bugzilla)

Tracking

Trunk
mozilla0.9.9
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

17 years ago
Go into Edit -> Prefs -> Navigator -> Smart Browsing
The Remove button is active even though nothing is highlighted. There's nothing
to remove but still the button is active. The button should only be active is
there's something that can be removed.

build 20020111
->joe
Assignee: sgehani → hewitt
QA Contact: sairuh → claudius
(Assignee)

Comment 2

17 years ago
Created attachment 65331 [details] [diff] [review]
Fix to disable remove button when no domains present in disabled list.
(Assignee)

Updated

17 years ago
Keywords: patch, review

Comment 3

17 years ago
-> samir since he has a patch
Assignee: hewitt → sgehani
(Assignee)

Comment 4

17 years ago
morse, please r.
hewitt, please sr.
Priority: -- → P4
Target Milestone: --- → mozilla0.9.9

Comment 5

17 years ago
Comment on attachment 65331 [details] [diff] [review]
Fix to disable remove button when no domains present in disabled list.

r=morse
Attachment #65331 - Flags: review+

Comment 6

17 years ago
Can you change this:
+    removeButton.disabled = "true";
+  else
+    removeButton.removeAttribute("disabled"); 

To this:
+    removeButton.disabled = true;
+  else
+    removeButton.disabled = false;

(Assignee)

Comment 7

17 years ago
Created attachment 68409 [details] [diff] [review]
Patch rev 2 with reviewer changes.

Hewitt,
Could you highlight why setting ``disabled'' to a JS boolean of false is better
than removing the attribute altogether?  And could you sr the change while
you're at it?  Thanks.
(Assignee)

Updated

17 years ago
Attachment #65331 - Attachment is obsolete: true

Comment 8

17 years ago
Comment on attachment 68409 [details] [diff] [review]
Patch rev 2 with reviewer changes.

sr=hewitt
Attachment #68409 - Flags: superreview+

Comment 9

17 years ago
The disabled property is boolean, so you shouldn't be passing strings like
"true" into it.  This will work for "true", but won't for "false".  Since we
have this propery, and it does the job of removing the attribute, might as well
be symmetrical and conventional and use it consistently.
(Assignee)

Comment 10

17 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Keywords: review
Resolution: --- → FIXED

Comment 11

17 years ago
If I ctrl+click to un-highlight the current selection in the list, shouldn't the
Remove button be disabled?
(Reporter)

Comment 12

17 years ago
v 20020221
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.