Go into Edit -> Prefs -> Navigator -> Smart Browsing The Remove button is active even though nothing is highlighted. There's nothing to remove but still the button is active. The button should only be active is there's something that can be removed. build 20020111
Assignee: sgehani → hewitt
QA Contact: sairuh → claudius
Created attachment 65331 [details] [diff] [review] Fix to disable remove button when no domains present in disabled list.
-> samir since he has a patch
Assignee: hewitt → sgehani
morse, please r. hewitt, please sr.
Priority: -- → P4
Target Milestone: --- → mozilla0.9.9
Comment on attachment 65331 [details] [diff] [review] Fix to disable remove button when no domains present in disabled list. r=morse
Attachment #65331 - Flags: review+
Can you change this: + removeButton.disabled = "true"; + else + removeButton.removeAttribute("disabled"); To this: + removeButton.disabled = true; + else + removeButton.disabled = false;
Created attachment 68409 [details] [diff] [review] Patch rev 2 with reviewer changes. Hewitt, Could you highlight why setting ``disabled'' to a JS boolean of false is better than removing the attribute altogether? And could you sr the change while you're at it? Thanks.
Comment on attachment 68409 [details] [diff] [review] Patch rev 2 with reviewer changes. sr=hewitt
Attachment #68409 - Flags: superreview+
The disabled property is boolean, so you shouldn't be passing strings like "true" into it. This will work for "true", but won't for "false". Since we have this propery, and it does the job of removing the attribute, might as well be symmetrical and conventional and use it consistently.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
If I ctrl+click to un-highlight the current selection in the list, shouldn't the Remove button be disabled?
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.