1197795 - Update Loop's library versions (eslint 1.2.1, sinon 1.16.1)

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

Eslint release notes:

http://eslint.org/blog/2015/08/eslint-1.1.0-released/
http://eslint.org/blog/2015/08/eslint-1.2.0-released/
http://eslint.org/blog/2015/08/eslint-1.2.1-released/

Sinon release notes:

http://sinonjs.org/Changelog.txt

Comment 1

[Mark Banner (:standard8)]

Attachment: Update Loop's library versions (eslint 1.2.1, sinon 1.16.1).

This does the simple updates. Not much new in eslint, but worth upgrading anyway I think.

The test_looppush_initialize.js changes are partially due to eslint - I think there's a regression in what it has as a valid case statement, however, I also think the code is more readable with hard-coded numbers than it is with the ++n.

sinon has various things we may/may not need, but I think the "bunch of bug fixes" bucket makes it reasonable to update whilst we're in the updating area ;-)

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8651749 [details] [diff] [review]
Update Loop's library versions (eslint 1.2.1, sinon 1.16.1).

Review of attachment 8651749 [details] [diff] [review]:
-----------------------------------------------------------------

Cool! When will we upgrade React? ;-)

::: browser/components/loop/test/xpcshell/test_looppush_initialize.js
@@ +164,2 @@
>      switch (++pushServerRequestCount) {
> +    case 1:

err, much better!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3540990c6cc0

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3540990c6cc0

Comment 5

[Ed Lee :Mardak]

I updated eslint to 1.2.1 but when I run all loop tests, I get a bunch of errors for missing block-spacing:

ui/ui-showcase.jsx
  7:1  error  Definition for rule 'block-spacing' was not found  block-spacing

✖ 128 problems (128 errors, 0 warnings)

$ grep block-spacing browser/components/loop/.eslintrc
    "block-spacing": [2, "always"],

Comment 6

[Mark Banner (:standard8)]

(In reply to Ed Lee :Mardak from comment #5)
> I updated eslint to 1.2.1 but when I run all loop tests, I get a bunch of
> errors for missing block-spacing:

Did you update both the version in standalone (make install), plus the global version?

Comment 7

[Ed Lee :Mardak]

Aha! That was it. I missed the standalone's copy with make install. Thanks.