1197811 - Pages are cut off in Nightly on gingerbread devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2015-08-24 16:51:04.png

Tested with:
Build: Firefox for Android 43.0a1 (2015-08-24)
Device: HTC Desire HD (Android 2.3.5) HTC Desire S (Android 2.3.3)

Steps to reproduce:
1. Open a new tab and go to a website

Expected results;
- The page is displayed correctly

Actual results:
- The page is cut off at the top of the screen
- A white bar is displayed at the bottom of the screen

Note:
- both normal and private browsing are affected

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Given the top is cropped, it might be related to the work Kats is doing for bug 1180295.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Yeah that's plausible. Does this only affect Android 2.3 devices? And do you have the "full-screen browsing" option under Settings>Display enabled or disabled?

Comment 3

[Teodora Vermesan (:TeoVermesan)]

I was able to reproduce this on two gingerbread device, but I was not able to reproduce it on Samsung S5 (Android 4.4) or Samsung Galaxy Tab 2 (Android 4.2.2). "Full-screen browsing" pref is enabled.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Ok, thanks. I don't have an ARMv7 gingerbread device any more, so I'll probably go to the Toronto office on wednesday to see if I can find one.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Just an update: I have a device that can reproduce this now. It seems like moving a SurfaceView with ViewHelper.setTranslation doesn't work on pre-Honeycomb, even though various places on the Internet say it should. I was able to get it sort of working by setting a margin and requesting Android to relayout, but that causes terrible black flashing while the SurfaceView is getting repositioned. My latest attempt instead puts the SurfaceView into a ScrollView and scrolls it to move the SurfaceView and that seems to be working well. I just need to handle some edge cases and clean up the patches.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Encapsulate the translation on the LayerView

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Don't assume the first child of the LayerView is the SurfaceView

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 3 - Don't rely on ViewHelper.setTranslationY to shift a SurfaceView because it doesn't

Comment 9

[Randall Barker [:rbarker]]

Comment on attachment 8654307 [details] [diff] [review]
Part 3 - Don't rely on ViewHelper.setTranslationY to shift a SurfaceView because it doesn't

>-        LayerView layerView = GeckoAppShell.getLayerView();
>-        if (layerView == null) {
>-            Log.e(LOGTAG, "Can't move selection because layerView is null");
>-            return;
>-        }
>-

Is this if null check not needed?

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I don't think so, even without my patch we were accessing GeckoAppShell.getLayerView().something inside the function before this null check, so it would have blown up if the layer view were null. Logically also it doesn't make sense that we would be moving a selection handle if there's no layer view, because we can't really select anything before gecko is up.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/32f284b4aeac
https://hg.mozilla.org/integration/fx-team/rev/5b05a359d909
https://hg.mozilla.org/integration/fx-team/rev/01ac27b605eb

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/32f284b4aeac
https://hg.mozilla.org/mozilla-central/rev/5b05a359d909
https://hg.mozilla.org/mozilla-central/rev/01ac27b605eb

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Pages are not cut off anymore at the top of the screen, so verified as fixed using:
Build: Firefox for Android 43.0a1 (2015-08-31)
Device: HTC Desire HD (Android 2.3.5)