Closed Bug 1197815 Opened 9 years ago Closed 9 years ago

|BluetoothHfpManager::IsNrecEnabled| is missing

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S6 (04Sep)
Project Flags:
blocking-b2g 2.2r+
Tracking Flags:
Tracking Status
firefox43 --- fixed
b2g-v2.2r --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(2 files, 1 obsolete file)

(for m-c) [01] Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled| (v2)
2.11 KB, patch
tzimmermann
: review+
Details | Diff | Splinter Review
(for branch 2.2r) Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled|
3.34 KB, patch
wiwang
: review+
Details | Diff | Splinter Review 
Bug 825149 broke the HFP fallback code.
Comment on attachment 8651777 [details] [diff] [review]
[01] Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled|

Review of attachment 8651777 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I forgot flatfish things.
Attachment #8651777 - Flags: review?(shuang) → review+
Changes since v1:

  - now builds with BlueZ
Attachment #8651777 - Attachment is obsolete: true
Attachment #8652368 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/492b7c1619ba
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
Hi Thomas,

Thanks for your help on adding this ! :)
Attachment #8652368 - Attachment description: [01] Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled| (v2) → [01] Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled| (v2) (for m-c)
I rebased the m-c patch to branch 2.2r here and carry r+ from previous patch.

----

Hi Wesley,

Could you help to handle this for 2.2r?
Thanks!
Flags: needinfo?(whuang)
Attachment #8657695 - Flags: review+
blocking-b2g: --- → 2.2r?
status-b2g-v2.2r: --- → affected
Keywords: checkin-needed
blocking-b2g: 2.2r? → 2.2r+
Flags: needinfo?(whuang)
Attachment #8652368 - Attachment description: [01] Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled| (v2) (for m-c) → (for m-c) [01] Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled| (v2)
Attachment #8657695 - Attachment description: Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled| (for branch 2.2r) → (for branch 2.2r) Bug 1197815: Add missing |BluetoothHfpManager::IsNrecEnabled|
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: