Definition sites of macros defined by functions not found

NEW
Unassigned

Status

Webtools
DXR
3 years ago
3 years ago

People

(Reporter: erik, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(firefox43 affected)

Details

(Reporter)

Description

3 years ago
(split off from 1196917)

1. Go to DXR.
2. Search for RegisterNonJSSizeOfTab.
3. Observe three hits:
   - 1 call;
   - 1 declaration in an idl file;
   - 1 declaration in the generated header from the idl file.
4. Click on the result with the file featuring the call, nsWindowMemoryReporter.cpp.
5. Click on "RegisterNonJSSizeOfTab", select "jump to definition".

This takes me to the declaration (in a generated .h) rather than any definition. Nathan would like to be sent to the defining macro at xpcom/base/nsMemoryReporterManager.cpp#2423.
(Reporter)

Comment 1

3 years ago
Nathan, that's quite a tangled web of macro calls. What made you choose GET_MEMORY_REPORTER_MANAGER as the defining macro rather than, say, DEFINE_REGISTER_SIZE_OF_TAB?
Flags: needinfo?(nfroyd)
(In reply to Erik Rose [:erik][:erikrose] from comment #1)
> Nathan, that's quite a tangled web of macro calls. What made you choose
> GET_MEMORY_REPORTER_MANAGER as the defining macro rather than, say,
> DEFINE_REGISTER_SIZE_OF_TAB?

Um, I thought I did pick DEFINE_REGISTER_SIZE_OF_TAB as the defining macro!  nsMemoryReporterManager.cpp, line 2423 reads (at least in my local copy):

DEFINE_REGISTER_SIZE_OF_TAB(NonJS);

Ah, but I see things have changed since I made that request!  MXR currently lists the above line as line 2477.  Whatever line in nsMemoryReporterManager.cpp the above text appears on, that's the line I want to be taken to. :)
Flags: needinfo?(nfroyd)
(Reporter)

Comment 3

3 years ago
Aha, the universe makes sense again! Thanks! :-)
You need to log in before you can comment on or make changes to this bug.