1197839 - Definition sites of macros defined by functions not found

Status: RESOLVED WONTFIX

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

(split off from 1196917)

1. Go to DXR.
2. Search for RegisterNonJSSizeOfTab.
3. Observe three hits:
   - 1 call;
   - 1 declaration in an idl file;
   - 1 declaration in the generated header from the idl file.
4. Click on the result with the file featuring the call, nsWindowMemoryReporter.cpp.
5. Click on "RegisterNonJSSizeOfTab", select "jump to definition".

This takes me to the declaration (in a generated .h) rather than any definition. Nathan would like to be sent to the defining macro at xpcom/base/nsMemoryReporterManager.cpp#2423.

Comment 1

[Erik Rose [:erik][:erikrose]]

Nathan, that's quite a tangled web of macro calls. What made you choose GET_MEMORY_REPORTER_MANAGER as the defining macro rather than, say, DEFINE_REGISTER_SIZE_OF_TAB?

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Erik Rose [:erik][:erikrose] from comment #1)
> Nathan, that's quite a tangled web of macro calls. What made you choose
> GET_MEMORY_REPORTER_MANAGER as the defining macro rather than, say,
> DEFINE_REGISTER_SIZE_OF_TAB?

Um, I thought I did pick DEFINE_REGISTER_SIZE_OF_TAB as the defining macro!  nsMemoryReporterManager.cpp, line 2423 reads (at least in my local copy):

DEFINE_REGISTER_SIZE_OF_TAB(NonJS);

Ah, but I see things have changed since I made that request!  MXR currently lists the above line as line 2477.  Whatever line in nsMemoryReporterManager.cpp the above text appears on, that's the line I want to be taken to. :)

Comment 3

[Erik Rose [:erik][:erikrose]]

Aha, the universe makes sense again! Thanks! :-)

Comment 4

[Sylvestre Ledru [:Sylvestre]]

DXR is no longer available. Searchfox is now replacing it.
See meta bug 1669906 & https://groups.google.com/g/mozilla.dev.platform/c/jDRjrq3l-CY for more details.